[coreboot-gerrit] New patch to review for coreboot: 73984b4 samus: Switch to using broadwell platform ASL

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Tue Mar 24 21:36:04 CET 2015


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8962

-gerrit

commit 73984b4b05555d96801b7f70d816e9acc0ac5946
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Fri Aug 22 11:05:26 2014 -0700

    samus: Switch to using broadwell platform ASL
    
    Instead of providing a local copy use the chipset provided one.
    
    BUG=chrome-os-partner:28234
    BRANCH=none
    TEST=build and boot on samus
    
    Original-Change-Id: I60dd9bbeefbf4298511abec54635c515fc9b1621
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/213793
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    (cherry picked from commit 9dc8e7ae61f0337aa145b7d99acc23852d1cfc9a)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I259be321e01e2047666b4be106dea59a5578d9d3
---
 src/mainboard/google/samus/acpi/platform.asl | 72 ----------------------------
 src/mainboard/google/samus/dsdt.asl          |  2 +-
 2 files changed, 1 insertion(+), 73 deletions(-)

diff --git a/src/mainboard/google/samus/acpi/platform.asl b/src/mainboard/google/samus/acpi/platform.asl
deleted file mode 100644
index e6aaf75..0000000
--- a/src/mainboard/google/samus/acpi/platform.asl
+++ /dev/null
@@ -1,72 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007-2009 coresystems GmbH
- * Copyright (C) 2012 Google Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-/* The APM port can be used for generating software SMIs */
-
-OperationRegion (APMP, SystemIO, 0xb2, 2)
-Field (APMP, ByteAcc, NoLock, Preserve)
-{
-	APMC, 8,	// APM command
-	APMS, 8		// APM status
-}
-
-/* Port 80 POST */
-
-OperationRegion (POST, SystemIO, 0x80, 1)
-Field (POST, ByteAcc, Lock, Preserve)
-{
-	DBG0, 8
-}
-
-/* SMI I/O Trap */
-Method(TRAP, 1, Serialized)
-{
-	Store (Arg0, SMIF)	// SMI Function
-	Store (0, TRP0)		// Generate trap
-	Return (SMIF)		// Return value of SMI handler
-}
-
-/* The _PIC method is called by the OS to choose between interrupt
- * routing via the i8259 interrupt controller or the APIC.
- *
- * _PIC is called with a parameter of 0 for i8259 configuration and
- * with a parameter of 1 for Local Apic/IOAPIC configuration.
- */
-
-Method(_PIC, 1)
-{
-	// Remember the OS' IRQ routing choice.
-	Store(Arg0, PICM)
-}
-
-/* The _PTS method (Prepare To Sleep) is called before the OS is
- * entering a sleep state. The sleep state number is passed in Arg0
- */
-
-Method(_PTS,1)
-{
-}
-
-/* The _WAK method is called on system wakeup */
-
-Method(_WAK,1)
-{
-	Return(Package(){0,0})
-}
diff --git a/src/mainboard/google/samus/dsdt.asl b/src/mainboard/google/samus/dsdt.asl
index ea0d01b..cfd2037 100644
--- a/src/mainboard/google/samus/dsdt.asl
+++ b/src/mainboard/google/samus/dsdt.asl
@@ -30,7 +30,7 @@ DefinitionBlock(
 )
 {
 	// Some generic macros
-	#include "acpi/platform.asl"
+	#include <soc/intel/broadwell/acpi/platform.asl>
 
 	// global NVS and variables
 	#include <soc/intel/broadwell/acpi/globalnvs.asl>



More information about the coreboot-gerrit mailing list