[coreboot-gerrit] Patch merged into coreboot/master: 627de92 libpayload ehci: Use 64-byte aligned data structures for periodic transfers

gerrit at coreboot.org gerrit at coreboot.org
Sat Mar 21 01:43:03 CET 2015


the following patch was just integrated into master:
commit 627de92d0a7d4a7b3c4f404810bc8157c359c155
Author: Jim Lin <jilin at nvidia.com>
Date:   Tue Sep 16 16:39:08 2014 +0800

    libpayload ehci: Use 64-byte aligned data structures for periodic transfers
    
    Chapter 3.1 "Periodic Frame List" of EHCI 1.0 specification says
    "Frame List Link pointers always reference memory objects that are
    32-byte aligned."
    jwerner at chromium.org suggests setting it to be 64-byte aligned for
    consistency with other EHCI queue structures.
    
    BUG=chrome-os-partner:31993
    TEST=Tested on nyan platform. Before adding patch, USB keyboard behind
    an external hub is not working to switch between "Default Locale" and
    "English" (after pressing ESC+REFRESH+POWER on embedded keyboard and
    later Left/Right-Arrow key on USB keyboard).
    
    Change-Id: Ie6259f2df20ae2618c2074e831fad087f227091d
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 23fc02e6ba3b17be4eaf18810ec6fc0d9c0e0b9a
    Original-Change-Id: If52ddc43ebd5d509c19f104928dced5bd09b1706
    Original-Signed-off-by: Jim Lin <jilin at nvidia.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/218403
    Original-Reviewed-by: Tom Warren <twarren at nvidia.com>
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: http://review.coreboot.org/8738
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/8738 for details.

-gerrit



More information about the coreboot-gerrit mailing list