[coreboot-gerrit] Patch merged into coreboot/master: e63990e libpayload: provide basic 64bit division implementation

gerrit at coreboot.org gerrit at coreboot.org
Sat Mar 21 01:40:05 CET 2015


the following patch was just integrated into master:
commit e63990ef34f39419d12ab9211d44621dc3768198
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Thu Nov 27 18:50:14 2014 -0800

    libpayload: provide basic 64bit division implementation
    
    These functions are usually provided by gcc lib, which is not supposed
    to be included on embedded platforms. This patch adds a no thrills C
    implementation.
    
    Other than MIPS platforms are happy using the gcc library provided
    implementation, but in case of Chrome OS MIPS toolchain the libraries
    are compiled with the small GOT, such that the entire data segment
    does not fit.
    
    With this implementation mips, arm and x86 targets build fine.
    
    BRANCH=none
    BUG=chrome-os-partner:31438
    
    TEST=checked the logic by incorporating this code into a C file and
         running a loop continuously comparing random inputs' division and
         left and right shift results.
    
         The test ran for extended periods of time without failure.
    
    Change-Id: I468acd2fdbcdd493a76758a394e79cad35f9535a
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 2cc5f8668dd2609408af8da5a74c5a3d063fc0d3
    Original-Change-Id: Ib46616d7eb0b2b497199270057514f730bb1cb0b
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/232232
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/8742
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See http://review.coreboot.org/8742 for details.

-gerrit



More information about the coreboot-gerrit mailing list