[coreboot-gerrit] New patch to review for coreboot: e238b91 x86: fix romstage_null.debug link w/o --gc-sections

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Sat Mar 21 01:32:02 CET 2015


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8850

-gerrit

commit e238b9199c24147ea82be203239f2398a4da3fc7
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Mar 20 19:28:55 2015 -0500

    x86: fix romstage_null.debug link w/o --gc-sections
    
    When adding gargabe collection to x86 the --gc-sections
    flags was inadvertently missed when linking romstage_null.debug.
    Fix this omission.
    
    Change-Id: I7d2700755afa78459c6f8707303a0e64936a1a9f
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/arch/x86/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index 7acdb57..5d49abc 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -201,7 +201,7 @@ romstage-libs ?=
 
 $(objcbfs)/romstage_null.debug: $$(romstage-objs) $(objgenerated)/romstage_null.ld $$(romstage-libs)
 	@printf "    LINK       $(subst $(obj)/,,$(@))\n"
-	$(LD_romstage) -nostdlib -nostartfiles -static -o $@ -L$(obj) $(COMPILER_RT_FLAGS_romstage) --start-group $(romstage-objs) $(romstage-libs) $(COMPILER_RT_romstage) --end-group -T $(objgenerated)/romstage_null.ld
+	$(LD_romstage) --gc-sections -nostdlib -nostartfiles -static -o $@ -L$(obj) $(COMPILER_RT_FLAGS_romstage) --start-group $(romstage-objs) $(romstage-libs) $(COMPILER_RT_romstage) --end-group -T $(objgenerated)/romstage_null.ld
 	$(OBJCOPY_romstage) --only-section .illegal_globals $(@) $(objcbfs)/romstage_null.offenders && \
 	$(NM_romstage) $(objcbfs)/romstage_null.offenders | grep -q ""; if [ $$? -eq 0 ]; then \
 		echo "Forbidden global variables in romstage:"; \



More information about the coreboot-gerrit mailing list