[coreboot-gerrit] New patch to review for coreboot: arm64: Move enabling floating point ahead of dev init

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Jun 16 12:32:08 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10558

-gerrit

commit 8ac1ea29f3b072f8645e9115f6bd274bb4f38d68
Author: Jimmy Zhang <jimmzhang at nvidia.com>
Date:   Wed Jun 3 17:34:41 2015 -0700

    arm64: Move enabling floating point ahead of dev init
    
    This CL is in preparing for tegra mtc that is invoked by dev init.
    mtc currently requires floating point instructions support.
    
    BUG=chrome-os-partner:40999
    BRANCH=none
    TEST=Build and boot smaug
    
    Change-Id: I470dfcd86026812d617f9ff4f4fcdce601195857
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 5e3f7336fc7cedf96dab4eff204616519856f831
    Original-Change-Id: I14c0003ce76ddf4b4ebb0cf171ea3c62cab55ef9
    Original-Signed-off-by: Jimmy Zhang <jimmzhang at nvidia.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/275112
    Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/arch/arm64/cpu_ramstage.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/arch/arm64/cpu_ramstage.c b/src/arch/arm64/cpu_ramstage.c
index 676590f..7b4b26a 100644
--- a/src/arch/arm64/cpu_ramstage.c
+++ b/src/arch/arm64/cpu_ramstage.c
@@ -118,12 +118,6 @@ static void init_this_cpu(void *arg)
 	/* Initialize the GIC. */
 	gic_init();
 
-	if (dev->ops != NULL && dev->ops->init != NULL) {
-		dev->initialized = 1;
-		printk(BIOS_DEBUG, "%s init\n", dev_path(dev));
-		dev->ops->init(dev);
-	}
-
 	/*
 	 * Disable coprocessor traps to EL3:
 	 * TCPAC [20] = 0, disable traps for EL2 accesses to CPTR_EL2 or HCPTR
@@ -145,6 +139,12 @@ static void init_this_cpu(void *arg)
 
 	/* Arch Timer init: setup cntfrq per CPU */
 	arm64_arch_timer_init();
+
+	if (dev->ops != NULL && dev->ops->init != NULL) {
+		dev->initialized = 1;
+		printk(BIOS_DEBUG, "%s init\n", dev_path(dev));
+		dev->ops->init(dev);
+	}
 }
 
 /* Fill in cpu_info structures according to device tree. */



More information about the coreboot-gerrit mailing list