[coreboot-gerrit] Patch merged into coreboot/master: buildgcc: Define $CMAKE only if clang package is built

gerrit at coreboot.org gerrit at coreboot.org
Tue Jun 16 08:42:28 CEST 2015


the following patch was just integrated into master:
commit cd5cdd3ba42371cc97b1464fd7b98de5bef05a6a
Author: David Hendricks <dhendrix at chromium.org>
Date:   Mon Jun 15 17:03:22 2015 -0700

    buildgcc: Define $CMAKE only if clang package is built
    
    This moves the CMAKE definition down into the case statement
    for $PACKAGE so that it is only required when the user wants to
    build clang.
    
    With this approach, "./buildgcc -P clang" will error out with the
    "ERROR: Missing tool:" message if cmake is not installed.
    
    Change-Id: I1e5c1bd67ade8f93ba0390df7f234deb47b9b18a
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/10556
    Tested-by: build bot (Jenkins)
    Reviewed-by: Francis Rowe <info at gluglug.org.uk>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/10556 for details.

-gerrit



More information about the coreboot-gerrit mailing list