[coreboot-gerrit] Patch merged into coreboot/master: pcengines/apu1: Remove unused smbus.asl

gerrit at coreboot.org gerrit at coreboot.org
Sun Jun 14 23:31:13 CEST 2015


the following patch was just integrated into master:
commit 982190d5f141e0729908abd625891103db191bf8
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date:   Sat Jun 13 13:06:17 2015 +0200

    pcengines/apu1: Remove unused smbus.asl
    
    The smbus.asl operation regions prevent the Linux i2c driver (i2c_piix4)
    for this chipset from claiming the ioport ranges and thus it fails to
    load.
    
    The methods defined in smbus.asl are not used in the DSDT and also don't
    exist in the DSDT of the vendor firmware.
    
    In particular due to the following check in i2c-piix4.c will fail unless
    acpi_enforce_resources=no is explicitly set on the Linux kernel
    parameters:
      if (acpi_check_region(piix4_smba, SMBIOSIZE, piix4_driver.name))
              return -ENODEV;
    
    Depending on kernel options the only error message printed is
    
      ACPI Warning: SystemIO range 0x0000000000000B00-0x0000000000000B07 conflicts with OpRegion 0x0000000000000B00-0x0000000000000B0B (\SMB0) (20150410/utaddress-254)
      ACPI: If an ACPI driver is available for this device, you should use it instead of the native driver
    
    However since it does not implement a standard interface there is no
    native ACPI driver for smbus.asl.
    
    Change-Id: Id8401e8b36f0e2412d490a92c20540a04d853125
    Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
    Reviewed-on: http://review.coreboot.org/10539
    Tested-by: build bot (Jenkins)
    Reviewed-by: Kyösti Mälkki <kyosti.malkki at gmail.com>


See http://review.coreboot.org/10539 for details.

-gerrit



More information about the coreboot-gerrit mailing list