[coreboot-gerrit] Patch set updated for coreboot: asrock/e350m1: Remove unused smbus.asl
Tobias Diedrich (ranma+coreboot@tdiedrich.de)
gerrit at coreboot.org
Sun Jun 14 23:05:19 CEST 2015
Tobias Diedrich (ranma+coreboot at tdiedrich.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10548
-gerrit
commit 9325a6440f7f80f3cc9485d9ef9c107efd9fc9fe
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date: Sun Jun 14 21:22:49 2015 +0200
asrock/e350m1: Remove unused smbus.asl
The smbus.asl operation regions prevent the Linux i2c driver (i2c_piix4)
for this chipset from claiming the ioport ranges and thus it fails to
load.
The methods defined in smbus.asl are not used in the DSDT and also don't
exist in the DSDT of the vendor firmware.
In particular due to the following check in i2c-piix4.c will fail unless
acpi_enforce_resources=no is explicitly set on the Linux kernel
parameters:
if (acpi_check_region(piix4_smba, SMBIOSIZE, piix4_driver.name))
return -ENODEV;
Depending on kernel options the only error message printed is
ACPI Warning: SystemIO range 0x0000000000000B00-0x0000000000000B07 conflicts with OpRegion 0x0000000000000B00-0x0000000000000B0B (\SMB0) (20150410/utaddress-254)
ACPI: If an ACPI driver is available for this device, you should use it instead of the native driver
However since it does not implement a standard interface there is no
native ACPI driver for smbus.asl.
Change-Id: I05b1993e1bc5e7a1cb25c730abbb6e729487d75d
Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
---
src/mainboard/asrock/e350m1/dsdt.asl | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mainboard/asrock/e350m1/dsdt.asl b/src/mainboard/asrock/e350m1/dsdt.asl
index 6dcf0a6..eb0946e 100644
--- a/src/mainboard/asrock/e350m1/dsdt.asl
+++ b/src/mainboard/asrock/e350m1/dsdt.asl
@@ -57,7 +57,6 @@ DefinitionBlock (
#include "acpi/sleep.asl"
#include "acpi/gpe.asl"
- #include <southbridge/amd/cimx/sb800/acpi/smbus.asl>
#include "acpi/thermal.asl"
}
/* End of ASL file */
More information about the coreboot-gerrit
mailing list