[coreboot-gerrit] New patch to review for coreboot: ec2ee1a buildgcc: Fail if a patch failed to apply

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Jun 9 22:46:51 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10487

-gerrit

commit ec2ee1a867004c8662fc411a770dc0317e799190
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Tue Jun 9 11:54:49 2015 -0700

    buildgcc: Fail if a patch failed to apply
    
    Otherwise one could end up with what they think is a coreboot toolchain
    but in fact it'd be missing some patches.
    
    Change-Id: Ic451f7061b822d0f4b64acc9976ba81fd544e85b
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 util/crossgcc/buildgcc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 740a035..1f73078 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -226,8 +226,10 @@ unpack_and_patch() {
 		for patch in patches/${dir}_*.patch; do
 			test -r $patch || continue
 			printf "   o $(basename $patch)\n"
-			$PATCH -s -N -p0 < $(echo $patch) || \
+			$PATCH -s -N -p0 < $(echo $patch) || {
 				printf "\n${RED}Failed $patch.${NC}\n"
+				exit 1
+			}
 		done
 		touch ${dir}/.unpack_success
 	)



More information about the coreboot-gerrit mailing list