[coreboot-gerrit] New patch to review for coreboot: 64e6fff buildgcc: Don't run autoconf

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Jun 9 22:46:51 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10486

-gerrit

commit 64e6fffe0a91800c26309e3cf982e95c39f1778d
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Tue Jun 9 11:52:28 2015 -0700

    buildgcc: Don't run autoconf
    
    gcc and binutils fixed their upstream tar balls, and running
    autoconf created more problems than it solved
    
    Change-Id: I0003dd597f521701405ff35923214435136b262d
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 util/crossgcc/buildgcc | 24 ++----------------------
 1 file changed, 2 insertions(+), 22 deletions(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index a30ef24..740a035 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -361,13 +361,7 @@ build_LIBELF() {
 }
 
 build_BINUTILS() {
-	# What a pain: binutils don't come with configure
-	# script anymore. Create it:
-	cd ../binutils-${BINUTILS_VERSION}/
-	autoconf
-	cd -
 	# Now build binutils
-	rm -f .failed
 	CC="$CC" ../binutils-${BINUTILS_VERSION}/configure --prefix=$TARGETDIR \
 		--target=${TARGETARCH} --disable-werror --disable-nls \
 		$USE_GOLD CFLAGS="$HOSTCFLAGS" || touch .failed
@@ -377,22 +371,8 @@ build_BINUTILS() {
 
 
 build_GCC() {
-	# Even worse than binutils: GCC does not come with configure
-	# script anymore, but also enforces an obsolete autoconf version
-	# to create it. This is a poster child of how autotools help make
-	# software portable.
-	cd ../gcc-${GCC_VERSION}
-	sed '/dnl Ensure exactly this Autoconf version is used/d' \
-		config/override.m4 > config/override.m4.new
-	autoconf_version=$(autoconf -V | grep "autoconf" | tr ' ' '\n' | tail -1)
-	sed "s/${GCC_AUTOCONF_VERSION}/${autoconf_version}/g" \
-		config/override.m4.new > config/override.m4
-	autoconf
-	cd -
-
-	# Now, finally, we can build gcc:
-	# GCC does not honour HOSTCFLAGS at all. CFLAGS are used for
-	# both target and host object files. This is pretty misdesigned.
+	# GCC does not honor HOSTCFLAGS at all. CFLAGS are used for
+	# both target and host object files.
 	# There's a work-around called CFLAGS_FOR_BUILD and CFLAGS_FOR_TARGET
 	# but it does not seem to work properly. At least the host library
 	# libiberty is not compiled with CFLAGS_FOR_BUILD.



More information about the coreboot-gerrit mailing list