[coreboot-gerrit] New patch to review for coreboot: intel/haswell: fix CHROMEOS builds for haswell

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Jul 29 11:01:10 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11061

-gerrit

commit 08fc2570b87938197baa346c9a74dc8838437aef
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Mon Jul 27 23:17:14 2015 +0200

    intel/haswell: fix CHROMEOS builds for haswell
    
    Compiler complained about potentially uninitialized variable.
    Fixes google/bolt, google/falco, google/panther, google/slippy
    
    BRANCH=none
    BUG=chromium:513990
    TEST=the mentioned boards build with CONFIG_CHROMEOS=y
    
    Change-Id: Ia28c833bd6ef8e1f7c820a61b41ce456eba51246
    Signed-off-by: Patrick Georgi <pgeorgi at google.com>
    Original-Commit-Id: 4566c355cc6828ab96e8d52bfad6ccbf6be6f7ce
    Original-Change-Id: I4d9a685373362f8a092b325efee3f816c056c708
    Original-Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/288850
    Original-Reviewed-by: Stefan Reinauer <reinauer at chromium.org>
---
 src/northbridge/intel/haswell/mrccache.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/northbridge/intel/haswell/mrccache.c b/src/northbridge/intel/haswell/mrccache.c
index 481110f..eb603f6 100644
--- a/src/northbridge/intel/haswell/mrccache.c
+++ b/src/northbridge/intel/haswell/mrccache.c
@@ -65,6 +65,7 @@ static int is_mrc_cache(struct mrc_data_container *mrc_cache)
 static u32 get_mrc_cache_region(struct mrc_data_container **mrc_region_ptr)
 {
 	size_t region_size = 0;
+	*mrc_region_ptr = NULL;
 
 	if (IS_ENABLED(CONFIG_CHROMEOS)) {
 		struct region_device rdev;



More information about the coreboot-gerrit mailing list