[coreboot-gerrit] New patch to review for coreboot: Braswell: Remove GOP from normal boot mode.

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Jul 20 22:28:54 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10990

-gerrit

commit b7dbb9d22b839fc168a1cc14b97453a527f0b212
Author: Abhay Kumar <abhay.kumar at intel.com>
Date:   Mon Jul 13 16:12:31 2015 -0700

    Braswell: Remove GOP from normal boot mode.
    
    Removing GOP initialization in normal mode since we don't need to
    show splash screen in normal mode. GOP will get initialized in dev
    and recovery mode.
    
    BRANCH=none
    BUG=None
    TEST=Splash screen will come only in dev or recovery mode.
    
    Change-Id: Ia5e12cf45d723f2f14c447e29b78119552d5e1ea
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 79d1c877343704ea51143b922d9ac9209be4d4b5
    Original-Change-Id: Id5ca99757427206413483d07b4f422b4c0abfa5d
    Original-Signed-off-by: Abhay <abhay.kumar at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/285300
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/common/vbt.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/soc/intel/common/vbt.c b/src/soc/intel/common/vbt.c
index 61eeaeb..0e46b70 100644
--- a/src/soc/intel/common/vbt.c
+++ b/src/soc/intel/common/vbt.c
@@ -24,6 +24,7 @@
 #include <lib.h>
 #include <soc/intel/common/ramstage.h>
 #include <string.h>
+#include <vendorcode/google/chromeos/chromeos.h>
 
 /* Locate VBT and pass it to FSP GOP */
 void load_vbt(uint8_t s3_resume, SILICON_INIT_UPD *params)
@@ -36,12 +37,15 @@ void load_vbt(uint8_t s3_resume, SILICON_INIT_UPD *params)
 		vbt_data = NULL;
 		printk(BIOS_DEBUG, "S3 resume do not pass VBT to GOP\n");
 	} else {
-		/* Get VBT data */
-		vbt_data = fsp_get_vbt(&vbt_len);
-		if (vbt_data != NULL)
-			printk(BIOS_DEBUG, "Passing VBT to GOP\n");
-		else
-			printk(BIOS_DEBUG, "VBT not found!\n");
+		if (developer_mode_enabled() || recovery_mode_enabled()) {
+			/* Get VBT data */
+			vbt_data = fsp_get_vbt(&vbt_len);
+			if (vbt_data != NULL)
+				printk(BIOS_DEBUG, "Passing VBT to GOP\n");
+			else
+				printk(BIOS_DEBUG, "VBT not found!\n");
+		} else
+			vbt_data = NULL;
 	}
 	params->PcdGraphicsConfigPtr = (u32)vbt_data;
 }



More information about the coreboot-gerrit mailing list