[coreboot-gerrit] New patch to review for coreboot: skylake: re-enable PCIe L1 sub states

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Jul 20 22:28:51 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10989

-gerrit

commit 4fae9ba9540c3dea5b6a640aab846a716057016a
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Mon Jul 13 13:50:34 2015 -0500

    skylake: re-enable PCIe L1 sub states
    
    All boards should have their L1 sub states workig now so
    re-enable the defaults.
    
    BUG=chrome-os-partner:41861
    BRANCH=None
    TEST=Built and booted glados into OS. PCIe devices show up still.
    
    Change-Id: Ic040fa108a662e15bb97cf8b0961f0f56683e146
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 380491f8267e60c3c6bc62486aaf21e201fcfd36
    Original-Change-Id: Idc6923b1fdd1c20d463eb7782be112f90b9adbfd
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/285170
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/soc/intel/skylake/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig
index 24fd961..207816d 100644
--- a/src/soc/intel/skylake/Kconfig
+++ b/src/soc/intel/skylake/Kconfig
@@ -31,8 +31,7 @@ config CPU_SPECIFIC_OPTIONS
 	select PCIEXP_ASPM
 	select PCIEXP_COMMON_CLOCK
 	select PCIEXP_CLK_PM
-	# External devices not working on glados
-	#select PCIEXP_L1_SUB_STATE
+	select PCIEXP_L1_SUB_STATE
 	select PLATFORM_USES_FSP1_1
 	select REG_SCRIPT
 	select RELOCATABLE_MODULES



More information about the coreboot-gerrit mailing list