[coreboot-gerrit] Patch set updated for coreboot: x86 realmode: Set up the 8254 timer before running option rom

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Wed Jul 15 21:38:06 CEST 2015


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10903

-gerrit

commit 39c6a59ff0259296783638b6a06f6d3e902b98cc
Author: zbao <fishbaozi at gmail.com>
Date:   Thu Jun 25 16:58:53 2015 -0400

    x86 realmode: Set up the 8254 timer before running option rom
    
    If the 8254 is not set up, the external graphics option rom
    hangs and never returns.
    
    The code is tested on AMD/bettong.
    
    Change-Id: I0022de9d9a275a7d4b7a331ae7fcf793b9f4c5f5
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
---
 src/device/oprom/realmode/x86.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c
index 14bcbc0..796c9fe 100644
--- a/src/device/oprom/realmode/x86.c
+++ b/src/device/oprom/realmode/x86.c
@@ -31,6 +31,7 @@
 #include <device/pci_ids.h>
 #include <lib/jpeg.h>
 #include <pc80/i8259.h>
+#include <pc80/i8254.h>
 #include <string.h>
 #include <vbe.h>
 
@@ -326,6 +327,7 @@ void run_bios(struct device *dev, unsigned long addr)
 	 * in some option roms.
 	 */
 	setup_i8259();
+	setup_i8254();
 
 	/* Set up some legacy information in the F segment */
 	setup_rombios();



More information about the coreboot-gerrit mailing list