[coreboot-gerrit] New patch to review for coreboot: amd/model_fxx rev.F: emit P-states when no intermediates exist
Jonathan A. Kollasch (jakllsch@kollasch.net)
gerrit at coreboot.org
Tue Jul 14 00:18:42 CEST 2015
Jonathan A. Kollasch (jakllsch at kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10910
-gerrit
commit e793719ea6206d28132f1bafa5c7795ab9e1c65f
Author: Jonathan A. Kollasch <jakllsch at kollasch.net>
Date: Mon Jul 13 17:05:07 2015 -0500
amd/model_fxx rev.F: emit P-states when no intermediates exist
Relevant for systems having processors that only have two (the minimum
and maximum) P-states, such as the Opteron 2210 at 1.0 and 1.8GHz.
Change-Id: Ic66fe6d10ce495c1bf21796cb7e1eb4e11e85283
Signed-off-by: Jonathan A. Kollasch <jakllsch at kollasch.net>
---
src/cpu/amd/model_fxx/powernow_acpi.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/cpu/amd/model_fxx/powernow_acpi.c b/src/cpu/amd/model_fxx/powernow_acpi.c
index f2aa596..ac505ee 100644
--- a/src/cpu/amd/model_fxx/powernow_acpi.c
+++ b/src/cpu/amd/model_fxx/powernow_acpi.c
@@ -194,11 +194,6 @@ static void pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP)
else
PstateStep_coef = 2;
- if (IntPstateSup == 0) {
- printk(BIOS_INFO, "No intermediate P-states are supported\n");
- goto write_pstates;
- }
-
/* Get the multiplier of the fid frequency */
/*
* Fid multiplier is always 100 revF and revG.
@@ -233,6 +228,11 @@ static void pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP)
Pstate_num++;
}
+ if (IntPstateSup == 0) {
+ printk(BIOS_SPEW, "No intermediate P-states are supported\n");
+ goto nointpstatesup;
+ }
+
Cur_feq = Max_feq;
Cur_fid = Max_fid;
/* Construct P1 state */
@@ -313,6 +313,7 @@ static void pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP)
Pstate_num++;
}
+nointpstatesup:
/* Construct P[Min] State */
if (Max_fid == 0x2A && Max_vid != 0x0) {
Pstate_fid[Pstate_num] = 0x2;
More information about the coreboot-gerrit
mailing list