[coreboot-gerrit] Patch set updated for coreboot: e70e150 Get rid of .car.global_data warnings for GCC build

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Fri Jan 30 00:51:22 CET 2015


Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8301

-gerrit

commit e70e15028a8abfa5904677e9db67d058006fb71a
Author: Martin Roth <gaumless at gmail.com>
Date:   Thu Jan 22 19:10:10 2015 -0700

    Get rid of .car.global_data warnings for GCC build
    
    The "used" attribute was added in commit 27cf2472 which caused these
    warnings to start appearing when using the standard coreboot GCC
    toolchain:
    
    {standard input}: Assembler messages:
    {standard input}:96: Warning: ignoring changed section type for .car.global_data
    {standard input}:96: Warning: ignoring changed section attributes for
    .car.global_data
    
    The # at the end of the section name causes the assembler to
    ignore everything following the name. I verified that the resulting
    binaries are the same with and without the #.
    
    Change-Id: Iaac8042533842ed887f33895f083b613a18f496a
    Signed-off-by: Martin Roth <gaumless at gmail.com>
---
 src/arch/x86/include/arch/early_variables.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/arch/x86/include/arch/early_variables.h b/src/arch/x86/include/arch/early_variables.h
index 2d5ae85..5394af3 100644
--- a/src/arch/x86/include/arch/early_variables.h
+++ b/src/arch/x86/include/arch/early_variables.h
@@ -23,8 +23,12 @@
 #ifdef __PRE_RAM__
 asm(".section .car.global_data,\"w\", at nobits");
 asm(".previous");
+#ifdef __clang__
 #define CAR_GLOBAL __attribute__((used,section(".car.global_data")))
 #else
+#define CAR_GLOBAL __attribute__((used,section(".car.global_data#")))
+#endif /* __clang__ */
+#else
 #define CAR_GLOBAL
 #endif
 



More information about the coreboot-gerrit mailing list