[coreboot-gerrit] New patch to review for coreboot: 623af9f lenovo/t530/romstage.c: add usb port description and missing oc config

Nicolas Reinecke (nr@das-labor.org) gerrit at coreboot.org
Thu Jan 29 23:50:56 CET 2015


Nicolas Reinecke (nr at das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8304

-gerrit

commit 623af9f2549007d096988d3a4ef3811c94095028
Author: Nicolas Reinecke <nr at das-labor.org>
Date:   Thu Jan 29 10:07:53 2015 +0100

    lenovo/t530/romstage.c: add usb port description and missing oc config
    
    OC2 at port 4 was missing. Verified with RCBA dump.
    
    Change-Id: Ide5701d53aeee28619204c7ac408662626aa11e4
    Signed-off-by: Nicolas Reinecke <nr at das-labor.org>
---
 src/mainboard/lenovo/t530/romstage.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/mainboard/lenovo/t530/romstage.c b/src/mainboard/lenovo/t530/romstage.c
index fbf47ac..f29d375 100644
--- a/src/mainboard/lenovo/t530/romstage.c
+++ b/src/mainboard/lenovo/t530/romstage.c
@@ -53,20 +53,20 @@ void rcba_config(void)
 }
 
 const struct southbridge_usb_port mainboard_usb_ports[] = {
-	{ 1, 1, 0 },
-	{ 1, 1, 1 },
-	{ 1, 2, 3 },
-	{ 1, 1, -1 },
-	{ 1, 1, -1 },
-	{ 1, 0, -1 },
-	{ 0, 0, -1 },
-	{ 1, 2, -1 },
-	{ 1, 0, -1 },
-	{ 1, 1, 5 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 3, -1 },
-	{ 1, 1, -1 },
+	{ 1, 1,  0 }, /* P0: USB double port upper, USB3, OC 0 */
+	{ 1, 1,  1 }, /* P1: USB double port lower, USB3, (EHCI debug) OC 1 */
+	{ 1, 2,  3 }, /* P2: Dock, USB3, OC 3 */
+	{ 1, 1, -1 }, /* P3: WWAN slot, no OC */
+	{ 1, 1,  2 }, /* P4: yellow USB, OC 2 */
+	{ 1, 0, -1 }, /* P5: ExpressCard slot, no OC */
+	{ 0, 0, -1 }, /* P6: color sensor(w530), no OC */
+	{ 1, 2, -1 }, /* P7: docking, no OC */
+	{ 1, 0, -1 }, /* P8: smart card reader, no OC */
+	{ 1, 1,  5 }, /* P9: USB port single (EHCI debug), OC 5 */
+	{ 1, 0, -1 }, /* P10: fingerprint reader, no OC */
+	{ 1, 0, -1 }, /* P11: bluetooth, no OC. */
+	{ 1, 3, -1 }, /* P12: wlan, no OC - disabled in vendor bios*/
+	{ 1, 1, -1 }, /* P13: camera, no OC */
 };
 
 void mainboard_get_spd(spd_raw_data *spd) {



More information about the coreboot-gerrit mailing list