[coreboot-gerrit] New patch to review for coreboot: 4717b21 coreboot tpm: Fix printk format specifiers

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Wed Jan 14 00:36:43 CET 2015


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8221

-gerrit

commit 4717b21e2cf4f08db650de0948a96e82a43c382a
Author: Furquan Shaikh <furquan at google.com>
Date:   Tue Jul 22 11:12:15 2014 -0700

    coreboot tpm: Fix printk format specifiers
    
    BUG=None
    BRANCH=None
    TEST=Compiles successfully
    
    Original-Change-Id: I828776724dce287d9a7eb732f2c9ecccf8d68229
    Original-Signed-off-by: Furquan Shaikh <furquan at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/209336
    Original-Tested-by: Furquan Shaikh <furquan at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Commit-Queue: Furquan Shaikh <furquan at chromium.org>
    (cherry picked from commit b50c9441ddaeabc5aa039f2141853ed7ba7a9d5b)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I6e81312609448c531345e592ee371ea53dc0916c
---
 src/drivers/i2c/tpm/tis.c | 2 +-
 src/drivers/i2c/tpm/tpm.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/drivers/i2c/tpm/tis.c b/src/drivers/i2c/tpm/tis.c
index 49bcdd7..696634d 100644
--- a/src/drivers/i2c/tpm/tis.c
+++ b/src/drivers/i2c/tpm/tis.c
@@ -145,7 +145,7 @@ out_recv:
 
 	rc = chip->vendor.recv(chip, (uint8_t *) buf, TPM_BUFSIZE);
 	if (rc < 0)
-		printk(BIOS_DEBUG, "tpm_transmit: tpm_recv: error %zd\n", rc);
+		printk(BIOS_DEBUG, "tpm_transmit: tpm_recv: error %d\n", rc);
 out:
 	return rc;
 }
diff --git a/src/drivers/i2c/tpm/tpm.c b/src/drivers/i2c/tpm/tpm.c
index 6f68789..bc36e35 100644
--- a/src/drivers/i2c/tpm/tpm.c
+++ b/src/drivers/i2c/tpm/tpm.c
@@ -178,7 +178,7 @@ static int iic_tpm_write_generic(uint8_t addr, uint8_t *buffer, size_t len,
 	int count;
 
 	if (len > TPM_BUFSIZE) {
-		printk(BIOS_DEBUG, "%s: Length %d is too large\n", __func__, len);
+		printk(BIOS_DEBUG, "%s: Length %zd is too large\n", __func__, len);
 		return -1;
 	}
 



More information about the coreboot-gerrit mailing list