[coreboot-gerrit] New patch to review for coreboot: 9d0a7fb rmodule: Fix 64-bit related typecast errors

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Wed Jan 14 00:31:58 CET 2015


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8220

-gerrit

commit 9d0a7fbc049b8dd00ea1ed6ad99090eb8331dfe6
Author: Furquan Shaikh <furquan at google.com>
Date:   Tue Jul 22 10:59:28 2014 -0700

    rmodule: Fix 64-bit related typecast errors
    
    BUG=None
    BRANCH=None
    TEST=Compiles successfully
    
    Original-Change-Id: I5687c24fcecd26e7656317eb8dde0f1f798e49fc
    Original-Signed-off-by: Furquan Shaikh <furquan at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/209335
    Original-Tested-by: Furquan Shaikh <furquan at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Commit-Queue: Furquan Shaikh <furquan at chromium.org>
    (cherry picked from commit 707cb3e274aa7eabc8e1792fc09d05b4c9e95913)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I2a40acbb14a5ba5c6e4d552b67a331256567d5b4
---
 src/lib/rmodule.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/lib/rmodule.c b/src/lib/rmodule.c
index 908297b..828a63d 100644
--- a/src/lib/rmodule.c
+++ b/src/lib/rmodule.c
@@ -152,17 +152,17 @@ static int rmodule_relocate(const struct rmodule *module)
 	reloc = module->relocations;
 	num_relocations = rmodule_number_relocations(module);
 
-	printk(BIOS_DEBUG, "Processing %zu relocs. Offset value of 0x%08x\n",
-	       num_relocations, adjustment);
+	printk(BIOS_DEBUG, "Processing %zu relocs. Offset value of 0x%08lx\n",
+	       num_relocations, (unsigned long)adjustment);
 
 	while (num_relocations > 0) {
 		uintptr_t *adjust_loc;
 
 		/* If the adjustment location is non-NULL adjust it. */
 		adjust_loc = rmodule_load_addr(module, *reloc);
-		printk(PK_ADJ_LEVEL, "Adjusting %p: 0x%08x -> 0x%08x\n",
-			       adjust_loc, *adjust_loc,
-			       *adjust_loc + adjustment);
+		printk(PK_ADJ_LEVEL, "Adjusting %p: 0x%08lx -> 0x%08lx\n",
+		       adjust_loc, (unsigned long) *adjust_loc,
+		       (unsigned long) *adjust_loc + adjustment);
 			*adjust_loc += adjustment;
 
 		reloc++;



More information about the coreboot-gerrit mailing list