[coreboot-gerrit] New patch to review for coreboot: 1b51755 AMD platforms: fix callout_entry doxygen errors

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Mon Jan 5 05:56:21 CET 2015


Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8098

-gerrit

commit 1b51755a52b778e50e35f375aa5172a38769360b
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Sun Jan 4 15:22:26 2015 -0700

    AMD platforms: fix callout_entry doxygen errors
    
    Somewhere along the line, the sb_cfg parameter name was changed to
    config, but this wasn't carried into the documentation or the function
    prototypes everywhere.
    
    Change-Id: Iccb0829c2f50370dddb70af915a6759316c4727a
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
---
 src/mainboard/amd/dinar/sb700_cfg.h        | 4 ++--
 src/mainboard/supermicro/h8qgi/sb700_cfg.h | 4 ++--
 src/mainboard/supermicro/h8scm/sb700_cfg.h | 4 ++--
 src/mainboard/tyan/s8226/sb700_cfg.h       | 4 ++--
 src/southbridge/amd/cimx/sb700/late.c      | 2 +-
 src/southbridge/amd/cimx/sb800/cfg.h       | 4 ++--
 src/southbridge/amd/cimx/sb800/late.c      | 2 +-
 src/southbridge/amd/cimx/sb900/late.c      | 2 +-
 8 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/mainboard/amd/dinar/sb700_cfg.h b/src/mainboard/amd/dinar/sb700_cfg.h
index 216c264..539a576 100644
--- a/src/mainboard/amd/dinar/sb700_cfg.h
+++ b/src/mainboard/amd/dinar/sb700_cfg.h
@@ -233,9 +233,9 @@ void sb700_cimx_config(AMDSBCFG *sb_cfg);
  *
  * @param[in] func    Southbridge CIMx Function ID.
  * @param[in] data    Southbridge Input Data.
- * @param[in] sb_cfg  Southbridge configuration structure pointer.
+ * @param[in] config  Southbridge configuration structure pointer.
  *
  */
-u32 sb700_callout_entry(u32 func, u32 data, void* sb_cfg);
+u32 sb700_callout_entry(u32 func, u32 data, void* config);
 
 #endif //_SB700_CFG_H_
diff --git a/src/mainboard/supermicro/h8qgi/sb700_cfg.h b/src/mainboard/supermicro/h8qgi/sb700_cfg.h
index 1df3fc5..1b1c636 100644
--- a/src/mainboard/supermicro/h8qgi/sb700_cfg.h
+++ b/src/mainboard/supermicro/h8qgi/sb700_cfg.h
@@ -233,9 +233,9 @@ void sb700_cimx_config(AMDSBCFG *sb_cfg);
  *
  * @param[in] func    Southbridge CIMx Function ID.
  * @param[in] data    Southbridge Input Data.
- * @param[in] sb_cfg  Southbridge configuration structure pointer.
+ * @param[in] config  Southbridge configuration structure pointer.
  *
  */
-u32 sb700_callout_entry(u32 func, u32 data, void* sb_cfg);
+u32 sb700_callout_entry(u32 func, u32 data, void* config);
 
 #endif //_SB700_CFG_H_
diff --git a/src/mainboard/supermicro/h8scm/sb700_cfg.h b/src/mainboard/supermicro/h8scm/sb700_cfg.h
index 40c89fa..2f3ece2 100644
--- a/src/mainboard/supermicro/h8scm/sb700_cfg.h
+++ b/src/mainboard/supermicro/h8scm/sb700_cfg.h
@@ -233,9 +233,9 @@ void sb700_cimx_config(AMDSBCFG *sb_cfg);
  *
  * @param[in] func    Southbridge CIMx Function ID.
  * @param[in] data    Southbridge Input Data.
- * @param[in] sb_cfg  Southbridge configuration structure pointer.
+ * @param[in] config  Southbridge configuration structure pointer.
  *
  */
-u32 sb700_callout_entry(u32 func, u32 data, void* sb_cfg);
+u32 sb700_callout_entry(u32 func, u32 data, void* config);
 
 #endif //_SB700_CFG_H_
diff --git a/src/mainboard/tyan/s8226/sb700_cfg.h b/src/mainboard/tyan/s8226/sb700_cfg.h
index c1ee84c..9c566a5 100644
--- a/src/mainboard/tyan/s8226/sb700_cfg.h
+++ b/src/mainboard/tyan/s8226/sb700_cfg.h
@@ -228,9 +228,9 @@ void sb700_cimx_config(AMDSBCFG *sb_cfg);
  *
  * @param[in] func    Southbridge CIMx Function ID.
  * @param[in] data    Southbridge Input Data.
- * @param[in] sb_cfg  Southbridge configuration structure pointer.
+ * @param[in] config  Southbridge configuration structure pointer.
  *
  */
-u32 sb700_callout_entry(u32 func, u32 data, void* sb_cfg);
+u32 sb700_callout_entry(u32 func, u32 data, void* config);
 
 #endif //_SB700_CFG_H_
diff --git a/src/southbridge/amd/cimx/sb700/late.c b/src/southbridge/amd/cimx/sb700/late.c
index 3fa6940..b0ec2dc 100644
--- a/src/southbridge/amd/cimx/sb700/late.c
+++ b/src/southbridge/amd/cimx/sb700/late.c
@@ -51,7 +51,7 @@ static AMDSBCFG *sb_config = &sb_late_cfg;
  *
  * @param[in] func      Southbridge CIMx Function ID.
  * @param[in] data      Southbridge Input Data.
- * @param[in] sb_config Southbridge configuration structure pointer.
+ * @param[in] config    Southbridge configuration structure pointer.
  *
  */
 u32 sb700_callout_entry(u32 func, u32 data, void* config)
diff --git a/src/southbridge/amd/cimx/sb800/cfg.h b/src/southbridge/amd/cimx/sb800/cfg.h
index 1fc3f7c..f6a3ab0 100644
--- a/src/southbridge/amd/cimx/sb800/cfg.h
+++ b/src/southbridge/amd/cimx/sb800/cfg.h
@@ -36,9 +36,9 @@ void sb800_cimx_config(AMDSBCFG *sb_cfg);
  *
  * @param[in] func    Southbridge CIMx Function ID.
  * @param[in] data    Southbridge Input Data.
- * @param[in] sb_cfg  Southbridge configuration structure pointer.
+ * @param[in] config  Southbridge configuration structure pointer.
  *
  */
-u32 sb800_callout_entry(u32 func, u32 data, void* sb_cfg);
+u32 sb800_callout_entry(u32 func, u32 data, void* config);
 
 #endif
diff --git a/src/southbridge/amd/cimx/sb800/late.c b/src/southbridge/amd/cimx/sb800/late.c
index d7f22d3..1eb865e 100644
--- a/src/southbridge/amd/cimx/sb800/late.c
+++ b/src/southbridge/amd/cimx/sb800/late.c
@@ -56,7 +56,7 @@ static AMDSBCFG *sb_config = &sb_late_cfg;
  *
  * @param[in] func      Southbridge CIMx Function ID.
  * @param[in] data      Southbridge Input Data.
- * @param[in] sb_config Southbridge configuration structure pointer.
+ * @param[in] config    Southbridge configuration structure pointer.
  *
  */
 u32 sb800_callout_entry(u32 func, u32 data, void* config)
diff --git a/src/southbridge/amd/cimx/sb900/late.c b/src/southbridge/amd/cimx/sb900/late.c
index e9f5ad6..6d47f05 100644
--- a/src/southbridge/amd/cimx/sb900/late.c
+++ b/src/southbridge/amd/cimx/sb900/late.c
@@ -54,7 +54,7 @@ static AMDSBCFG *sb_config = &sb_late_cfg;
  *
  * @param[in] func      Southbridge CIMx Function ID.
  * @param[in] data      Southbridge Input Data.
- * @param[in] sb_config Southbridge configuration structure pointer.
+ * @param[in] config    Southbridge configuration structure pointer.
  *
  */
 u32 sb900_callout_entry(u32 func, u32 data, void* config)



More information about the coreboot-gerrit mailing list