[coreboot-gerrit] New patch to review for coreboot: d9968b2 AMD Mainboards - rd890_cfg.c: Fix doxygen warnings

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Mon Jan 5 05:56:19 CET 2015


Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8097

-gerrit

commit d9968b2d78461c1f0395d4864f53c711bf3d80de
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Sun Jan 4 15:12:21 2015 -0700

    AMD Mainboards - rd890_cfg.c: Fix doxygen warnings
    
    Remove variable types from the param declaration.
    
    Change-Id: Ia6a3d36fcf01d7a52bb1a31cfdb47d88bf612d79
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
---
 src/mainboard/amd/dinar/rd890_cfg.c        | 6 +++---
 src/mainboard/supermicro/h8qgi/rd890_cfg.c | 6 +++---
 src/mainboard/supermicro/h8scm/rd890_cfg.c | 6 +++---
 src/mainboard/tyan/s8226/rd890_cfg.c       | 6 +++---
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/mainboard/amd/dinar/rd890_cfg.c b/src/mainboard/amd/dinar/rd890_cfg.c
index 69c4d41..deceae3 100644
--- a/src/mainboard/amd/dinar/rd890_cfg.c
+++ b/src/mainboard/amd/dinar/rd890_cfg.c
@@ -104,9 +104,9 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
  *
  * prototype AGESA_STATUS (*CALLOUT_ENTRY) (UINT32 Param1, UINTN Param2, VOID* ConfigPtr);
  *
- * @param[in] u32 func               Northbridge CIMx CallBackId
- * @param[in] u32 data               Northbridge Input Data.
- * @param[in] AMD_NB_CONFIG *config  Northbridge configuration structure pointer.
+ * @param[in] func     Northbridge CIMx CallBackId
+ * @param[in] data     Northbridge Input Data.
+ * @param[in] *config  Northbridge configuration structure pointer.
  *
  */
 static u32 rd890_callout_entry(u32 func, u32 data, void *config)
diff --git a/src/mainboard/supermicro/h8qgi/rd890_cfg.c b/src/mainboard/supermicro/h8qgi/rd890_cfg.c
index a5f6650..7ea9e86 100644
--- a/src/mainboard/supermicro/h8qgi/rd890_cfg.c
+++ b/src/mainboard/supermicro/h8qgi/rd890_cfg.c
@@ -104,9 +104,9 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
  *
  * prototype AGESA_STATUS (*CALLOUT_ENTRY) (UINT32 Param1, UINTN Param2, VOID* ConfigPtr);
  *
- * @param[in] u32 func               Northbridge CIMx CallBackId
- * @param[in] u32 data               Northbridge Input Data.
- * @param[in] AMD_NB_CONFIG *config  Northbridge configuration structure pointer.
+ * @param[in] func     Northbridge CIMx CallBackId
+ * @param[in] data     Northbridge Input Data.
+ * @param[in] *config  Northbridge configuration structure pointer.
  *
  */
 static u32 rd890_callout_entry(u32 func, u32 data, void *config)
diff --git a/src/mainboard/supermicro/h8scm/rd890_cfg.c b/src/mainboard/supermicro/h8scm/rd890_cfg.c
index a5f6650..7ea9e86 100644
--- a/src/mainboard/supermicro/h8scm/rd890_cfg.c
+++ b/src/mainboard/supermicro/h8scm/rd890_cfg.c
@@ -104,9 +104,9 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
  *
  * prototype AGESA_STATUS (*CALLOUT_ENTRY) (UINT32 Param1, UINTN Param2, VOID* ConfigPtr);
  *
- * @param[in] u32 func               Northbridge CIMx CallBackId
- * @param[in] u32 data               Northbridge Input Data.
- * @param[in] AMD_NB_CONFIG *config  Northbridge configuration structure pointer.
+ * @param[in] func     Northbridge CIMx CallBackId
+ * @param[in] data     Northbridge Input Data.
+ * @param[in] *config  Northbridge configuration structure pointer.
  *
  */
 static u32 rd890_callout_entry(u32 func, u32 data, void *config)
diff --git a/src/mainboard/tyan/s8226/rd890_cfg.c b/src/mainboard/tyan/s8226/rd890_cfg.c
index a5f6650..7ea9e86 100644
--- a/src/mainboard/tyan/s8226/rd890_cfg.c
+++ b/src/mainboard/tyan/s8226/rd890_cfg.c
@@ -104,9 +104,9 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
  *
  * prototype AGESA_STATUS (*CALLOUT_ENTRY) (UINT32 Param1, UINTN Param2, VOID* ConfigPtr);
  *
- * @param[in] u32 func               Northbridge CIMx CallBackId
- * @param[in] u32 data               Northbridge Input Data.
- * @param[in] AMD_NB_CONFIG *config  Northbridge configuration structure pointer.
+ * @param[in] func     Northbridge CIMx CallBackId
+ * @param[in] data     Northbridge Input Data.
+ * @param[in] *config  Northbridge configuration structure pointer.
  *
  */
 static u32 rd890_callout_entry(u32 func, u32 data, void *config)



More information about the coreboot-gerrit mailing list