[coreboot-gerrit] Patch merged into coreboot/master: 0780d67 util/cbfstool: Fix byte-ordering for payload type field.

gerrit at coreboot.org gerrit at coreboot.org
Sat Jan 3 17:33:15 CET 2015


the following patch was just integrated into master:
commit 0780d67ffe8ef754ace0912114e2b1e772554990
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Fri May 16 10:14:05 2014 +0800

    util/cbfstool: Fix byte-ordering for payload type field.
    
    In https://chromium-review.googlesource.com/181272 the payload->type has been
    changed to big-endian (network ordering) but the cbfs_image is still parsing
    type as host ordering, which caused printing cbfs image verbosely
    (cbfstool imge print -v) to fail to find entry field and print numerous
    garbage output.
    
    Payload fields should be always parsed in big-endian (network ordering).
    
    BUG=none
    TEST=make; cbfstool image.bin print -v -v -v # see payloads correctly
    
    Original-Change-Id: If1ac355b8847fb54988069f694bd2f317ce49a1a
    Original-Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/200158
    Original-Reviewed-by: Ronald Minnich <rminnich at chromium.org>
    (cherry picked from commit 423f7dd28f8b071692d57401e144232d5ee2e479)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I5a4694e887c7ff48d8d0713bb5808c29256141a9
    Reviewed-on: http://review.coreboot.org/8005
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
    Tested-by: build bot (Jenkins)


See http://review.coreboot.org/8005 for details.

-gerrit



More information about the coreboot-gerrit mailing list