[coreboot-gerrit] New patch to review for coreboot: 0986b7d kbuild: Don't require intel/common changes for every soc

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Wed Apr 29 19:47:27 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10031

-gerrit

commit 0986b7d280d9ce83a0f56feb47a4eaf07ce25e6b
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Wed Apr 29 10:45:22 2015 -0700

    kbuild: Don't require intel/common changes for every soc
    
    In the true spirit of separating components more strictly
    and allowing to add new components to coreboot without touching
    existing code, move Intel common code selection to the soc
    Kconfig and out of src/soc/intel/common/Makefile.inc
    
    Change-Id: I0a70656bb9f4550b6088e9f45e68b5106c0eb9af
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 src/soc/intel/baytrail/Kconfig    | 1 +
 src/soc/intel/broadwell/Kconfig   | 1 +
 src/soc/intel/common/Kconfig      | 5 +++++
 src/soc/intel/common/Makefile.inc | 2 +-
 4 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/baytrail/Kconfig b/src/soc/intel/baytrail/Kconfig
index 214a1ac..0b3e176 100644
--- a/src/soc/intel/baytrail/Kconfig
+++ b/src/soc/intel/baytrail/Kconfig
@@ -37,6 +37,7 @@ config CPU_SPECIFIC_OPTIONS
 	select TSC_MONOTONIC_TIMER
 	select TSC_SYNC_MFENCE
 	select UDELAY_TSC
+	select SOC_INTEL_COMMON
 
 config BOOTBLOCK_CPU_INIT
 	string
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig
index d840632..91249ee 100644
--- a/src/soc/intel/broadwell/Kconfig
+++ b/src/soc/intel/broadwell/Kconfig
@@ -48,6 +48,7 @@ config CPU_SPECIFIC_OPTIONS
 	select TSC_SYNC_MFENCE
 	select UDELAY_TSC
 	select PER_DEVICE_ACPI_TABLES
+	select SOC_INTEL_COMMON
 
 config BOOTBLOCK_CPU_INIT
 	string
diff --git a/src/soc/intel/common/Kconfig b/src/soc/intel/common/Kconfig
index 1dce4e3..8b5cef3 100644
--- a/src/soc/intel/common/Kconfig
+++ b/src/soc/intel/common/Kconfig
@@ -1,3 +1,8 @@
+config SOC_INTEL_COMMON
+	bool
+	help
+	  common code for Intel SOCs
+
 if HAVE_MRC
 
 config CACHE_MRC_SETTINGS
diff --git a/src/soc/intel/common/Makefile.inc b/src/soc/intel/common/Makefile.inc
index 46786e2..6d40aa7 100644
--- a/src/soc/intel/common/Makefile.inc
+++ b/src/soc/intel/common/Makefile.inc
@@ -1,4 +1,4 @@
-ifeq ($(CONFIG_SOC_INTEL_BAYTRAIL)$(CONFIG_SOC_INTEL_BROADWELL),y)
+ifeq ($(CONFIG_SOC_INTEL_COMMON),y)
 
 ramstage-y += hda_verb.c
 ramstage-$(CONFIG_CACHE_MRC_SETTINGS) += nvm.c



More information about the coreboot-gerrit mailing list