[coreboot-gerrit] New patch to review for coreboot: 448570a intel/broadwell: bootstate mechanism doesn't exist in SMM

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Apr 29 19:12:00 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10030

-gerrit

commit 448570a8ed231b535a283a36ba6f77005af0866c
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Wed Apr 29 19:11:30 2015 +0200

    intel/broadwell: bootstate mechanism doesn't exist in SMM
    
    So don't try to use it.
    
    Change-Id: Ia600ba654bde36d3ea8a0f3185afae00fe50bfe9
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
 src/soc/intel/broadwell/spi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/soc/intel/broadwell/spi.c b/src/soc/intel/broadwell/spi.c
index 0fca059..44285a9 100644
--- a/src/soc/intel/broadwell/spi.c
+++ b/src/soc/intel/broadwell/spi.c
@@ -312,12 +312,14 @@ void spi_init(void)
 	pci_write_config_byte(dev, 0xdc, bios_cntl | 0x1);
 }
 
+#ifndef __SMM__
 static void spi_init_cb(void *unused)
 {
 	spi_init();
 }
 
 BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_ENTRY, spi_init_cb, NULL);
+#endif
 
 int spi_claim_bus(struct spi_slave *slave)
 {



More information about the coreboot-gerrit mailing list