[coreboot-gerrit] New patch to review for coreboot: 9a46ae8 google/storm: indicate start of normal boot on LED ring

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9923

-gerrit

commit 9a46ae804c65db184f184dffc5e6e5c1f96d6e5c
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Mon Apr 13 16:32:45 2015 -0700

    google/storm: indicate start of normal boot on LED ring
    
    Instead of switching off the LED ring for the normal boot path, turn
    it on with the dedicated pattern, indicating that the device firmware
    has started executing.
    
    BRANCH=storm
    BUG=chrome-os-partner:39044
    TEST=program the new firmware on an SP5 device and verify that the new
         'normal boot' pattern is displayed in all following scenarios:
    
     - power up the device (the pattern shows within the first second)
    
     - boot the device to bash prompt and restart.
    
     - press the recovery button and reboot the device. Once the LED ring
       shows the 'recovery button pressed' pattern, release the recovery
       button.
    
    Change-Id: Iedd66d2575ad587af77e35d23efb22a83a92858b
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 092358bd17a323d0bd2fec555f43cb587486bbec
    Original-Change-Id: I24de45326eab83b57bcf16b5598388f81c7d0f00
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/265536
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/google/storm/chromeos.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/storm/chromeos.c b/src/mainboard/google/storm/chromeos.c
index 0076b3c..a28ecd7 100644
--- a/src/mainboard/google/storm/chromeos.c
+++ b/src/mainboard/google/storm/chromeos.c
@@ -106,6 +106,7 @@ static enum switch_state get_switch_state(void)
 
 	if (!sampled_value) {
 		saved_state = no_req;
+		display_pattern(WWR_NORMAL_BOOT);
 		return saved_state;
 	}
 
@@ -139,7 +140,7 @@ static enum switch_state get_switch_state(void)
 		}
 	} else {
 		saved_state = no_req;
-		display_pattern(WWR_ALL_OFF);
+		display_pattern(WWR_NORMAL_BOOT);
 	}
 
 	return saved_state;