[coreboot-gerrit] New patch to review for coreboot: d9ca633 veyron: move setup_chromeos_gpios() prototype to board.h

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9733

-gerrit

commit d9ca633344fc2d169a05ff37429c1190be47e4b9
Author: Julius Werner <jwerner at chromium.org>
Date:   Thu Jan 15 17:00:21 2015 -0800

    veyron: move setup_chromeos_gpios() prototype to board.h
    
    I always had that TODO comment in there but I had already forgotten what
    I even meant by it. It's really just a simple cleanup... this function
    is (currently) veyron-specific and doesn't belong in common code.
    
    BRANCH=veyron
    BUG=None
    TEST=Booted Jerry.
    
    Change-Id: Iccd6130c90e67b8ee905e188857c99deda966f14
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: d188398704575ad2fedc2a715e609521da2332b0
    Original-Change-Id: I6ce701a15a6542a615d3d81f70aa71662567d4fa
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/241190
---
 src/mainboard/google/veyron_brain/board.h  | 2 +-
 src/mainboard/google/veyron_danger/board.h | 2 +-
 src/mainboard/google/veyron_jerry/board.h  | 2 +-
 src/mainboard/google/veyron_mighty/board.h | 2 +-
 src/mainboard/google/veyron_pinky/board.h  | 2 +-
 src/mainboard/google/veyron_rialto/board.h | 2 +-
 src/mainboard/google/veyron_speedy/board.h | 2 +-
 src/vendorcode/google/chromeos/chromeos.h  | 3 ---
 8 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/google/veyron_brain/board.h b/src/mainboard/google/veyron_brain/board.h
index 96159d4..6e6a62c 100644
--- a/src/mainboard/google/veyron_brain/board.h
+++ b/src/mainboard/google/veyron_brain/board.h
@@ -25,6 +25,6 @@
 
 #define GPIO_RESET	GPIO(0, B, 5)
 
-/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */
+void setup_chromeos_gpios(void);
 
 #endif	/* __MAINBOARD_GOOGLE_VEYRON_BRAIN_BOARD_H */
diff --git a/src/mainboard/google/veyron_danger/board.h b/src/mainboard/google/veyron_danger/board.h
index bd826aa..4d0e8be 100644
--- a/src/mainboard/google/veyron_danger/board.h
+++ b/src/mainboard/google/veyron_danger/board.h
@@ -26,6 +26,6 @@
 #define GPIO_BACKLIGHT  GPIO(7, A, 3)
 #define GPIO_RESET	GPIO(0, B, 5)
 
-/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */
+void setup_chromeos_gpios(void);
 
 #endif	/* __MAINBOARD_GOOGLE_VEYRON_BRAIN_BOARD_H */
diff --git a/src/mainboard/google/veyron_jerry/board.h b/src/mainboard/google/veyron_jerry/board.h
index 3d567de..2f8a341 100644
--- a/src/mainboard/google/veyron_jerry/board.h
+++ b/src/mainboard/google/veyron_jerry/board.h
@@ -26,6 +26,6 @@
 #define GPIO_BACKLIGHT	GPIO(7, A, 0)
 #define GPIO_RESET	GPIO(0, B, 5)
 
-/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */
+void setup_chromeos_gpios(void);
 
 #endif	/* __MAINBOARD_GOOGLE_VEYRON_JERRY_BOARD_H */
diff --git a/src/mainboard/google/veyron_mighty/board.h b/src/mainboard/google/veyron_mighty/board.h
index 280568a..2ca1a41 100644
--- a/src/mainboard/google/veyron_mighty/board.h
+++ b/src/mainboard/google/veyron_mighty/board.h
@@ -26,6 +26,6 @@
 #define GPIO_BACKLIGHT	GPIO(7, A, 0)
 #define GPIO_RESET	GPIO(0, B, 5)
 
-/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */
+void setup_chromeos_gpios(void);
 
 #endif	/* __MAINBOARD_GOOGLE_VEYRON_MIGHTY_BOARD_H */
diff --git a/src/mainboard/google/veyron_pinky/board.h b/src/mainboard/google/veyron_pinky/board.h
index 8fe102f..45590e7 100644
--- a/src/mainboard/google/veyron_pinky/board.h
+++ b/src/mainboard/google/veyron_pinky/board.h
@@ -26,6 +26,6 @@
 #define GPIO_BACKLIGHT	GPIO(7, A, 0)
 #define GPIO_RESET	(board_id() > 0 ? GPIO(0, B, 5) : GPIO(0, B, 2))
 
-/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */
+void setup_chromeos_gpios(void);
 
 #endif	/* __MAINBOARD_GOOGLE_VEYRON_PINKY_BOARD_H */
diff --git a/src/mainboard/google/veyron_rialto/board.h b/src/mainboard/google/veyron_rialto/board.h
index 7cd8da6..7c6fa37 100644
--- a/src/mainboard/google/veyron_rialto/board.h
+++ b/src/mainboard/google/veyron_rialto/board.h
@@ -25,6 +25,6 @@
 
 #define GPIO_RESET	GPIO(0, B, 5)
 
-/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */
+void setup_chromeos_gpios(void);
 
 #endif	/* __MAINBOARD_GOOGLE_VEYRON_RIALTO_BOARD_H */
diff --git a/src/mainboard/google/veyron_speedy/board.h b/src/mainboard/google/veyron_speedy/board.h
index 817aac2..f98854e 100644
--- a/src/mainboard/google/veyron_speedy/board.h
+++ b/src/mainboard/google/veyron_speedy/board.h
@@ -26,6 +26,6 @@
 #define GPIO_BACKLIGHT	GPIO(7, A, 0)
 #define GPIO_RESET	GPIO(0, B, 5)
 
-/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */
+void setup_chromeos_gpios(void);
 
 #endif	/* __MAINBOARD_GOOGLE_VEYRON_SPEEDY_BOARD_H */
diff --git a/src/vendorcode/google/chromeos/chromeos.h b/src/vendorcode/google/chromeos/chromeos.h
index 13a4fe3..1184fa5 100644
--- a/src/vendorcode/google/chromeos/chromeos.h
+++ b/src/vendorcode/google/chromeos/chromeos.h
@@ -26,9 +26,6 @@
 #include "vboot_common.h"
 #include "vboot2/misc.h"
 
-/*for mainboard use only*/
-void setup_chromeos_gpios(void);
-
 /* functions implemented in vbnv.c: */
 int get_recovery_mode_from_vbnv(void);
 int vboot_wants_oprom(void);