[coreboot-gerrit] Patch merged into coreboot/master: 4913cb7 storm: Fix timer init order problem

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 13 17:37:04 CEST 2015


the following patch was just integrated into master:
commit 4913cb78d2e8a37e80128fbd82466d1825dba413
Author: Julius Werner <jwerner at chromium.org>
Date:   Thu Dec 4 14:57:52 2014 -0800

    storm: Fix timer init order problem
    
    Commit 257aaee9e3a (arm: Add bootblock_mainboard_early_init() for
    pre-console initialization) inadvertently moved the timer initialization
    after console initialization for IPQ806x, which is apparently not a good
    idea for this platform. This patch solves the issue by moving
    init_timer() to bootblock_mainboard_early_init(), which is the new hook
    explicitly provided to perform pre-console tasks.
    
    BRANCH=None
    BUG=None
    TEST=Built and booted Storm with 257aaee9e reverted. Noticed that it was
    already broken. Bisected coreboot and tracked down breakage to commit
    a126a62f (ipq8064: use the new utility to build bootblock). Built and
    booted successfully with this patch and a revert of a126a62f to confirm
    that the bug in question here is fixed.
    
    Change-Id: I4a3faa2aec8ff1fbbe6c389f1d048475aa944418
    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Commit-Id: 752d1f879f9bd841f18bd84842491f747458cf52
    Original-Change-Id: Ie4aa2d06cb6fda6d5ff8dd5ea052257fb7b8a24b
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/233290
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-by: Vadim Bendebury <vbendeb at chromium.org>
    Reviewed-on: http://review.coreboot.org/9574
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/9574 for details.

-gerrit



More information about the coreboot-gerrit mailing list