[coreboot-gerrit] Patch merged into coreboot/master: e6cf3c6 TPM: Reduce buffer size to fix stack overflow

gerrit at coreboot.org gerrit at coreboot.org
Fri Apr 10 20:06:26 CEST 2015


the following patch was just integrated into master:
commit e6cf3c6f78149b4c11c7a53f27e684bd560c0ac2
Author: Julius Werner <jwerner at chromium.org>
Date:   Fri Dec 19 14:38:51 2014 -0800

    TPM: Reduce buffer size to fix stack overflow
    
    The TPM driver by default allocates a 4K transfer buffer on the stack,
    which leads to lots of fun on boards with 2K or 3K stack sizes. On
    RK3288 this ends up writing over random memory sections which dependent
    on the memlayout of the day might contain timestamp data (no big deal)
    or page tables (-> bad time).
    
    This patch fixes the problem by reducing the buffer size to slightly
    above 1K, which still seems to work as far as I can tell. There was
    already some really odd code that #undef'ed this value and redefined it
    with the lower number in one .c file (unfortunately not the one with the
    buffer declaration), with no explanation whatsoever... I'm removing that
    and just assume the smaller value will be fine for everything.
    
    BRANCH=veyron
    BUG=None
    TEST=Booted Pinky and Falco.
    
    Change-Id: I440a5662b41cbd8b7becab3113262e1140b7f763
    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Commit-Id: 3d3288041b6629b7623b9d58816e782e72836b81
    Original-Change-Id: Idf80f44cbfb9617c56b64a5c88ebedf7fcb4ec71
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/236976
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/9481
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/9481 for details.

-gerrit



More information about the coreboot-gerrit mailing list