[coreboot-gerrit] New patch to review for coreboot: cd93517 kconfig: calloc/xcalloc: Fix argument order

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Mon Apr 6 01:48:03 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9313

-gerrit

commit cd93517b0150698b82b2b23a586abd4e0c409872
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Mon Apr 6 01:30:44 2015 +0200

    kconfig: calloc/xcalloc: Fix argument order
    
    The calloc() and xcalloc() functions takes @nmemb first and then @size.  Fix all w/
    pattern "calloc\s*(\s*sizeof".
    
    Signed-off-by: Arjun Sreedharan <arjun024 at gmail.com>
    Cc: "Yann E. MORIN" <yann.morin.1998 at free.fr>
    Cc: Ingo Molnar <mingo at redhat.com>
    Cc: Paul Mackerras <paulus at samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra at chello.nl>
    Link: http://lkml.kernel.org/r/1417866043-1877-1-git-send-email-arjun024@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme at redhat.com>
    
    Change-Id: I8b51cc59b3f3631b93b7e215fec5bf140cc2cbf9
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 util/kconfig/mconf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/util/kconfig/mconf.c b/util/kconfig/mconf.c
index 60826e3..1d651c1 100644
--- a/util/kconfig/mconf.c
+++ b/util/kconfig/mconf.c
@@ -330,10 +330,10 @@ static void set_subtitle(void)
 	list_for_each_entry(sp, &trail, entries) {
 		if (sp->text) {
 			if (pos) {
-				pos->next = xcalloc(sizeof(*pos), 1);
+				pos->next = xcalloc(1, sizeof(*pos));
 				pos = pos->next;
 			} else {
-				subtitles = pos = xcalloc(sizeof(*pos), 1);
+				subtitles = pos = xcalloc(1, sizeof(*pos));
 			}
 			pos->text = sp->text;
 		}



More information about the coreboot-gerrit mailing list