New patch to review for coreboot: aced2e3 kconfig: Fix warning "‘jump’ may be used uninitialized"

[Stefan Reinauer (stefan.reinauer@coreboot.org)]

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9312

-gerrit

commit aced2e33b748d992e38bbc1bf4794fac2964e2dc
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Mon Apr 6 01:27:55 2015 +0200

    kconfig: Fix warning "‘jump’ may be used uninitialized"
    
    Warning:
    In file included from scripts/kconfig/zconf.tab.c:2537:0:
    scripts/kconfig/menu.c: In function ‘get_symbol_str’:
    scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         jump->offset = strlen(r->s);
    
    Simplifies the test logic because (head && local) means (jump != 0)
    and makes GCC happy when checking if the jump pointer was initialized.
    
    Signed-off-by: Peter Kümmel <syntheticpp at gmx.net>
    Signed-off-by: Michal Marek <mmarek at suse.cz>
    
    Change-Id: I43de391c9573a28c66d17e7dc535033be39060de
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 util/kconfig/menu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/util/kconfig/menu.c b/util/kconfig/menu.c
index a26cc5d..72c9dba 100644
--- a/util/kconfig/menu.c
+++ b/util/kconfig/menu.c
@@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
 {
 	int i, j;
 	struct menu *submenu[8], *menu, *location = NULL;
-	struct jump_key *jump;
+	struct jump_key *jump = NULL;
 
 	str_printf(r, _("Prompt: %s\n"), _(prop->text));
 	menu = prop->menu->parent;
@@ -586,7 +586,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
 		str_printf(r, _("  Location:\n"));
 		for (j = 4; --i >= 0; j += 2) {
 			menu = submenu[i];
-			if (head && location && menu == location)
+			if (jump && menu == location)
 				jump->offset = strlen(r->s);
 			str_printf(r, "%*c-> %s", j, ' ',
 				   _(menu_get_prompt(menu)));