[coreboot-gerrit] New patch to review for coreboot: dc4b997 mainboard/intel/cougar_canyon2/romstage.c: Missing prototype

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Wed Nov 19 01:58:29 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7517

-gerrit

commit dc4b997a0e3aafc96726c3d4c9bf92cec1f83d2c
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Wed Nov 19 11:55:33 2014 +1100

    mainboard/intel/cougar_canyon2/romstage.c: Missing prototype
    
    Fix warning thrown by Clang due to missing prototype for main
    entry point function in -ffreestanding. main() is as any other
    function in freestanding and so a prototype is strictly needed.
    
    Change-Id: Icb29ced0306d5089049a35b1d8862f86a555ff1f
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/intel/cougar_canyon2/romstage.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mainboard/intel/cougar_canyon2/romstage.c b/src/mainboard/intel/cougar_canyon2/romstage.c
index cc956a7..9ac70ef 100644
--- a/src/mainboard/intel/cougar_canyon2/romstage.c
+++ b/src/mainboard/intel/cougar_canyon2/romstage.c
@@ -173,6 +173,7 @@ static void rcba_config(void)
 	RCBA32(FD) = reg32;
 }
 
+void main(FSP_INFO_HEADER *fsp_info_header); // XXX find a better place dorothy
 void main(FSP_INFO_HEADER *fsp_info_header)
 {
 #if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)



More information about the coreboot-gerrit mailing list