[coreboot-gerrit] Patch set updated for coreboot: 809a02f amd hudson: Base HUDSON_FWM_POSITION on actual ROMSIZE
Tobias Diedrich (ranma+coreboot@tdiedrich.de)
gerrit at coreboot.org
Wed Nov 19 01:23:23 CET 2014
Tobias Diedrich (ranma+coreboot at tdiedrich.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7479
-gerrit
commit 809a02f01bb502f9b16f1c663705bff80133d2fb
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date: Sun Nov 16 13:50:30 2014 +0100
amd hudson: Base HUDSON_FWM_POSITION on actual ROMSIZE
Hudson Kconfig is using BOARD_ROMSIZE to generate HUDSON_FWM_POSITION, make
it use COREBOOT_ROMSIZE instead, so it'll work when selecting a non-default
romsize.
Change-Id: I531418d6a8457b37df87fea131cfa59f2802d7ac
Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
---
src/southbridge/amd/agesa/hudson/Kconfig | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig
index a2a43a4..89078ed 100644
--- a/src/southbridge/amd/agesa/hudson/Kconfig
+++ b/src/southbridge/amd/agesa/hudson/Kconfig
@@ -115,12 +115,16 @@ config HUDSON_FWM
if HUDSON_FWM
config HUDSON_FWM_POSITION
- hex "Hudson Firmware ROM Position"
- default 0xFFF20000 if BOARD_ROMSIZE_KB_1024
- default 0xFFE20000 if BOARD_ROMSIZE_KB_2048
- default 0xFFC20000 if BOARD_ROMSIZE_KB_4096
- default 0xFF820000 if BOARD_ROMSIZE_KB_8192
- default 0xFF020000 if BOARD_ROMSIZE_KB_16384
+ hex "Hudson Firmware ROM Position"
+ # TODO: Doing the 4GiB - ROMSIZE + 128kiB calculation in Kconfig is
+ # ugly. CBFS will fail the day we need to put aligned 64kiB and 32kiB
+ # files right next to each other? Also if one of these new blobs begins
+ # to write/erase SPI pages, our CBFS headers are at risk.
+ default 0xFFF20000 if COREBOOT_ROMSIZE_KB_1024
+ default 0xFFE20000 if COREBOOT_ROMSIZE_KB_2048
+ default 0xFFC20000 if COREBOOT_ROMSIZE_KB_4096
+ default 0xFF820000 if COREBOOT_ROMSIZE_KB_8192
+ default 0xFF020000 if COREBOOT_ROMSIZE_KB_16384
help
Hudson requires the firmware MUST be located at
a specific address (ROM start address + 0x20000), otherwise
More information about the coreboot-gerrit
mailing list