[coreboot-gerrit] New patch to review for coreboot: 86add32 elog: Probe for SPI flash on bus indicated by Kconfig variable

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Wed Dec 10 03:43:59 CET 2014


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7753

-gerrit

commit 86add3230408ba9169580d2516fbbcf6468a4f5b
Author: David Hendricks <dhendrix at chromium.org>
Date:   Mon Apr 14 14:57:36 2014 -0700

    elog: Probe for SPI flash on bus indicated by Kconfig variable
    
    This replaces a hard-coded bus number of 0 with a Kconfig variable,
    CONFIG_BOOT_MEDIA_SPI_BUS. This removes an assumption made for x86
    where this value is always 0 and makes it easy to add support for
    other platforms where the bus number for the backing SPI flash is
    more arbitrary.
    
    BUG=none
    BRANCH=none
    TEST=tested on Nyan (bus=4) and Link (bus=0)
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    
    Original-Change-Id: I1e878a1628af7f4ccc2f39a70b2190192767e536
    Original-Reviewed-on: https://chromium-review.googlesource.com/194854
    Original-Tested-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: Gabe Black <gabeblack at chromium.org>
    Original-Commit-Queue: David Hendricks <dhendrix at chromium.org>
    (cherry picked from commit 371c6c14d8d4b98004eebce7049a88a219682bc4)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: Ie105b4654e028098f2137c96e4309b8d85f096df
---
 src/drivers/elog/elog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c
index 227bd82..059b089 100644
--- a/src/drivers/elog/elog.c
+++ b/src/drivers/elog/elog.c
@@ -548,7 +548,7 @@ int elog_init(void)
 
 	/* Prepare SPI */
 	spi_init();
-	elog_spi = spi_flash_probe(0, 0);
+	elog_spi = spi_flash_probe(CONFIG_BOOT_MEDIA_SPI_BUS, 0);
 	if (!elog_spi) {
 		printk(BIOS_ERR, "ELOG: Unable to find SPI flash\n");
 		return -1;



More information about the coreboot-gerrit mailing list