[coreboot-gerrit] Patch merged into coreboot/master: 986349d vendorcode/amd/agesa/fam15tn: Clean #includes in public headers

gerrit at coreboot.org gerrit at coreboot.org
Sat Dec 6 05:43:22 CET 2014


the following patch was just integrated into master:
commit 986349df6492068a7f01fdfd8a6e65b93eb1bc17
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Sat Mar 29 16:52:46 2014 -0500

    vendorcode/amd/agesa/fam15tn: Clean #includes in public headers
    
    Right now, coreboot code using AGESA headers can only build if all the
    AGESA path are given to the compiler via the "-I" option. This is sub-
    optimal, as it requires us to have every AGESA source directory
    specified as a compiler include path. This pollutes our global include
    paths.
    
    We restrict the compiler include paths to only allow "AGESA_ROOT/" and
    "AGESA_ROOT/Include". We then modify the AGESA headers to specify
    non-local include files relative to "AGESA_ROOT/Include".
    
    We use the convention that includes relative to the directory of the
    header are included as "path/to/header.h", while includes relative to
    AGESA_ROOT are included as <path/to/header.h>.
    
    This change allows building coreboot code based on AGESA with the
    limited subset of include paths, but does not allow AGESA itself to
    build with this restricted subset.
    
    Change-Id: I31102273c8caa8d6b1d80774bfd35711825bec03
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
    Reviewed-on: http://review.coreboot.org/5424
    Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Tested-by: build bot (Jenkins)


See http://review.coreboot.org/5424 for details.

-gerrit



More information about the coreboot-gerrit mailing list