[coreboot-gerrit] New patch to review for coreboot: 923d175 AGESA fam12 fam14: Revert to old behaviour when accessing eventlog

[Kyösti Mälkki (kyosti.malkki@gmail.com)]

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7639

-gerrit

commit 923d1759083f519c008b9630fa8b4ec2f907f6a4
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Wed Dec 3 18:55:06 2014 +0200

    AGESA fam12 fam14: Revert to old behaviour when accessing eventlog
    
    There is some problem reading back from AGESA eventlog.
    
    When commit 1aa35c6 added the change of passing StdHeader.HeapStatus,
    like we should, we see the following failed ASSERTs and
    execution would continue with invalid NULL pointer dereferences.
    
       agesawrapper_amdinitpost() returned AGESA_WARNING
       ASSERTION FAILED: file 'src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c',  line 578
       ASSERTION FAILED: file 'src/vendorcode/amd/agesa/f14/Proc/CPU/cpuEventLog.c',  line 283
    
    Revert to old behaviour that without those failing ASSERTs until we
    have a proper solution for this. This will print a series of events
    like this in early romstage:
    
       EventLog:	EventClass = 2, EventInfo = 8040100.
       	Param1 = a00a, Param2 = 0.
    	Param3 = 0, Param4 = 0.
       agesawrapper_amdinitpost() returned AGESA_WARNING
    
    Change-Id: Ic6e13a5ec5ba567cbd665785e87929871d8e234d
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/northbridge/amd/agesa/eventlog.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/northbridge/amd/agesa/eventlog.c b/src/northbridge/amd/agesa/eventlog.c
index 90640d9..e153f9e 100644
--- a/src/northbridge/amd/agesa/eventlog.c
+++ b/src/northbridge/amd/agesa/eventlog.c
@@ -719,7 +719,10 @@ static void amd_readeventlog(AMD_CONFIG_PARAMS *StdHeader)
 	AmdEventParams.StdHeader.CalloutPtr = (CALLOUT_ENTRY) &GetBiosCallout;
 	AmdEventParams.StdHeader.Func = 0;
 	AmdEventParams.StdHeader.ImageBasePtr = 0;
+
+#if !IS_ENABLED(CONFIG_NORTHBRIDGE_AMD_AGESA_FAMILY14) && !IS_ENABLED(CONFIG_NORTHBRIDGE_AMD_AGESA_FAMILY12)
 	AmdEventParams.StdHeader.HeapStatus = StdHeader->HeapStatus;
+#endif
 
 	AmdReadEventLog(&AmdEventParams);
 	while (AmdEventParams.EventClass != 0) {