[coreboot-gerrit] Patch set updated for coreboot: 1dce3c9 southbridge/amd/cimx/sb800: Uninitialized variables in config func

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sun Aug 3 12:44:19 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6474

-gerrit

commit 1dce3c9c71ce8e439e4ba0ba91e304b66d92ee09
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Sun Aug 3 19:42:02 2014 +1000

    southbridge/amd/cimx/sb800: Uninitialized variables in config func
    
    Both 'SbSpiSpeedSupport' and 'UsbRxMode' are uninitiated upon return from
    a 'sb800_cimx_config()' call.
    
    Change-Id: I32237ff97fafc3e69627d427e54268dcb039e12c
    Found-by: Coverity Scan
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/southbridge/amd/cimx/sb800/cfg.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/southbridge/amd/cimx/sb800/cfg.c b/src/southbridge/amd/cimx/sb800/cfg.c
index 78aab79..91b6067 100644
--- a/src/southbridge/amd/cimx/sb800/cfg.c
+++ b/src/southbridge/amd/cimx/sb800/cfg.c
@@ -122,10 +122,13 @@ void sb800_cimx_config(AMDSBCFG *sb_config)
 	sb_config->SpreadSpectrum = SPREAD_SPECTRUM;
 	sb_config->PciClks = PCI_CLOCK_CTRL;
 	sb_config->HpetTimer = HPET_TIMER;
+	sb_config->SbSpiSpeedSupport = 1;
 
 	/* USB */
 	sb_config->USBMODE.UsbModeReg = USB_CONFIG;
 	sb_config->SbUsbPll = 0;
+	/* CG PLL multiplier for USB Rx 1.1 mode (0=disable, 1=enable) */
+	sb_config->UsbRxMode = 1;
 
 	/* SATA */
 	sb_config->SataClass = SATA_MODE;



More information about the coreboot-gerrit mailing list