[coreboot-gerrit] New patch to review for coreboot: 072d89e intel/fsp_bd82x6x: Fix cycle error

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sun Aug 3 12:42:39 CEST 2014


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6479

-gerrit

commit 072d89e4e680f67b5e3c5c29f5946c60268e38ea
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sun Aug 3 12:41:29 2014 +0200

    intel/fsp_bd82x6x: Fix cycle error
    
    Some copy-pasta snuck in that reintroduced an error
    already fixed in #3435.
    
    Change-Id: I47db23e88fa09c73b4cf3e99fe2d0ed2ac30fd80
    Found-by: Coverity Scan
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/southbridge/intel/fsp_bd82x6x/smi.c        | 2 +-
 src/southbridge/intel/fsp_bd82x6x/smihandler.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/southbridge/intel/fsp_bd82x6x/smi.c b/src/southbridge/intel/fsp_bd82x6x/smi.c
index bc47395..97d0ce4 100644
--- a/src/southbridge/intel/fsp_bd82x6x/smi.c
+++ b/src/southbridge/intel/fsp_bd82x6x/smi.c
@@ -172,7 +172,7 @@ static void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
 {
 	int i;
 	printk(BIOS_DEBUG, "ALT_GP_SMI_STS: ");
-	for (i=15; i<= 0; i--) {
+	for (i=15; i>= 0; i--) {
 		if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16));
 	}
 	printk(BIOS_DEBUG, "\n");
diff --git a/src/southbridge/intel/fsp_bd82x6x/smihandler.c b/src/southbridge/intel/fsp_bd82x6x/smihandler.c
index 8ff36e6..059a003 100644
--- a/src/southbridge/intel/fsp_bd82x6x/smihandler.c
+++ b/src/southbridge/intel/fsp_bd82x6x/smihandler.c
@@ -165,7 +165,7 @@ static void dump_gpe0_status(u32 gpe0_sts)
 {
 	int i;
 	printk(BIOS_DEBUG, "GPE0_STS: ");
-	for (i=31; i<= 16; i--) {
+	for (i=31; i => 16; i--) {
 		if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
 	}
 	if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");



More information about the coreboot-gerrit mailing list