[coreboot-gerrit] Patch merged into coreboot/master: 20ed4b7 ASRock E350M1: irq_tables.c: Include `cpu/amd/amdfam14.h` for `get_bus_conf`

gerrit at coreboot.org gerrit at coreboot.org
Sat Mar 30 14:07:22 CET 2013

the following patch was just integrated into master:
commit 20ed4b7bf3fd8d270f28d7ea35ba03b3861f58a0
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Mar 29 14:36:33 2013 +0100

    ASRock E350M1: irq_tables.c: Include `cpu/amd/amdfam14.h` for `get_bus_conf`
    When building the ASRock E350M1, the following warning is shown.
        $ make # on Jenkins (build server)
            CC         mainboard/asrock/e350m1/irq_tables.ramstage.o
        src/mainboard/asrock/e350m1/irq_tables.c: In function 'write_pirq_routing_table':
        src/mainboard/asrock/e350m1/irq_tables.c:64:2: warning: implicit declaration of function 'get_bus_conf' [-Wimplicit-function-declaration]
    Including the header file `cpu/amd/amdfam14.h` declaring the
    function addresses this warning.
    The same change was done in the following commit for the
    AMD Persimmon board.
        commit d7a696d0f229abccc95ff411f28d91b9b796ab74
        Author: efdesign98 <efdesign98 at gmail.com>
        Date:   Thu Sep 15 15:24:26 2011 -0600
            Persimmon updates for AMD F14 rev C0
            Reviewed-on: http://review.coreboot.org/137
    Change-Id: I40b5735feb7116961ca0c4d6940ec55cdf42d3c6
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2956
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martin.roth at se-eng.com>

Build-Tested: build bot (Jenkins) at Fri Mar 29 21:51:21 2013, giving +1
Reviewed-By: Martin Roth <martin.roth at se-eng.com> at Sat Mar 30 02:16:55 2013, giving +2
See http://review.coreboot.org/2956 for details.


More information about the coreboot-gerrit mailing list