[coreboot-gerrit] Patch merged into coreboot/master: 2120460 ASRock E350M1: get_bus_conf.c: Include `agesawrapper.h` for `agesawrapper_amdinitlate`

gerrit at coreboot.org gerrit at coreboot.org
Sat Mar 30 14:06:55 CET 2013


the following patch was just integrated into master:
commit 21204600378d71655f90c781d400c0249d1cd284
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Mar 29 13:23:31 2013 +0100

    ASRock E350M1: get_bus_conf.c: Include `agesawrapper.h` for `agesawrapper_amdinitlate`
    
    When building the ASRock E350M1, the following warning is shown.
    
        $ make # on Jenkins (build server)
        […]
            CC         mainboard/asrock/e350m1/get_bus_conf.ramstage.o
        src/mainboard/asrock/e350m1/get_bus_conf.c: In function 'get_bus_conf':
        src/mainboard/asrock/e350m1/get_bus_conf.c:82:3: warning: implicit declaration of function 'agesawrapper_amdinitlate' [-Wimplicit-function-declaration]
        […]
    
    Including the header file `agesawrapper.h` declaring the function
    `agesawrapper_amdinitlate` fixes this warning.
    
    All AMD Family 14 based boards already include that header file. For
    example for the board AMD Persimmon the following patch fixed this
    warning.
    
        commit d7a696d0f229abccc95ff411f28d91b9b796ab74
        Author: efdesign98 <efdesign98 at gmail.com>
        Date:   Thu Sep 15 15:24:26 2011 -0600
    
            Persimmon updates for AMD F14 rev C0
    
            Reviewed-on: http://review.coreboot.org/137
    
    Change-Id: I695420b7071e07cb7d4667b2479b9a26ea13723d
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2955
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martin.roth at se-eng.com>

Build-Tested: build bot (Jenkins) at Fri Mar 29 14:02:01 2013, giving +1
Reviewed-By: Martin Roth <martin.roth at se-eng.com> at Fri Mar 29 21:40:37 2013, giving +2
See http://review.coreboot.org/2955 for details.

-gerrit



More information about the coreboot-gerrit mailing list