[coreboot-gerrit] New patch to review for coreboot: 416fbd6 Some wait_for_valid functions return 1 incorrectly. Fixed to return -1.
Andrew Wu (arw@dmp.com.tw)
gerrit at coreboot.org
Fri Aug 2 08:58:42 CEST 2013
Andrew Wu (arw at dmp.com.tw) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3843
-gerrit
commit 416fbd60034f1b9fbc09761b4b6a3293ca7854ab
Author: Andrew Wu <arw at dmp.com.tw>
Date: Fri Aug 2 14:45:03 2013 +0800
Some wait_for_valid functions return 1 incorrectly. Fixed to return -1.
codec_init expects wait_for_valid returns -1 for timeout, not 1.
Change-Id: I0f2a3ebb1934d0adaf13765434526bbc9efca9a3
Signed-off-by: Andrew Wu <arw at dmp.com.tw>
---
src/southbridge/amd/sb600/hda.c | 2 +-
src/southbridge/amd/sb700/hda.c | 2 +-
src/southbridge/amd/sb800/hda.c | 2 +-
src/southbridge/intel/sch/audio.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/southbridge/amd/sb600/hda.c b/src/southbridge/amd/sb600/hda.c
index 3b118af..26adf11 100644
--- a/src/southbridge/amd/sb600/hda.c
+++ b/src/southbridge/amd/sb600/hda.c
@@ -208,7 +208,7 @@ static int wait_for_valid(u32 base)
udelay(1);
}
- return 1;
+ return -1;
}
static void codec_init(u32 base, int addr)
diff --git a/src/southbridge/amd/sb700/hda.c b/src/southbridge/amd/sb700/hda.c
index 98cb75f..bf4c754 100644
--- a/src/southbridge/amd/sb700/hda.c
+++ b/src/southbridge/amd/sb700/hda.c
@@ -130,7 +130,7 @@ static int wait_for_valid(u32 base)
udelay(1);
}
- return 1;
+ return -1;
}
static void codec_init(u32 base, int addr)
diff --git a/src/southbridge/amd/sb800/hda.c b/src/southbridge/amd/sb800/hda.c
index 1be44fb..e2d6960 100644
--- a/src/southbridge/amd/sb800/hda.c
+++ b/src/southbridge/amd/sb800/hda.c
@@ -132,7 +132,7 @@ static int wait_for_valid(u32 base)
udelay(1);
}
- return 1;
+ return -1;
}
static void codec_init(u32 base, int addr)
diff --git a/src/southbridge/intel/sch/audio.c b/src/southbridge/intel/sch/audio.c
index 701c944..f3eb034 100644
--- a/src/southbridge/intel/sch/audio.c
+++ b/src/southbridge/intel/sch/audio.c
@@ -187,7 +187,7 @@ static int wait_for_valid(u32 base)
udelay(1);
}
- return 1;
+ return -1;
}
static void codec_init(struct device *dev, u32 base, int addr)
More information about the coreboot-gerrit
mailing list