[SerialICE] New patch to review for serialice: 47c3f20 EPIA-M850: Fix decoding of SMBus IO BAR to prevent 'nil' error

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Mon Jul 22 21:46:41 CEST 2013


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3798

-gerrit

commit 47c3f201fc4c23c4f5720bdae8cdb1a47fc0a6ed
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Mon Jul 22 14:41:57 2013 -0500

    EPIA-M850: Fix decoding of SMBus IO BAR to prevent 'nil' error
    
    The filter seems to have been using an obsolete form, thus causing a 'nil'
    error when SerialICE tried to run it. Fix this error.
    
    Change-Id: Ib650e9bd1661574a1f7987803cfc131c12035a5d
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 SerialICE/simba/mainboard/via_epia_m_850.lua | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/SerialICE/simba/mainboard/via_epia_m_850.lua b/SerialICE/simba/mainboard/via_epia_m_850.lua
index 8f10ba3..aa5ebb3 100644
--- a/SerialICE/simba/mainboard/via_epia_m_850.lua
+++ b/SerialICE/simba/mainboard/via_epia_m_850.lua
@@ -111,8 +111,9 @@ filter_mainboard = {
 load_filter("intel_smbus")
 load_filter("via_bars")
 
-function smbus_bar_hook(dev, reg, base)
-	intel_smbus_setup(base, 0x20)
+function smbus_bar_hook(f, action)
+	local base = bit32.band(action.data, 0xfff0)
+	intel_smbus_setup(base, 0x10)
 end
 
 dev_sb_lpc = {



More information about the SerialICE mailing list