[SeaBIOS] [PATCH v2 1/1] SeaVGABios/cbvga: Fix bpp for coreboot framebuffer

Kevin O'Connor kevin at koconnor.net
Tue Sep 18 19:40:11 CEST 2018


On Tue, Sep 11, 2018 at 09:29:39PM -0500, Matt DeVillier wrote:
> Commit 4b42cc4 [SeaVGABios/cbvga: Advertise correct pixel format] neglected
> to wrap the cbfb mask size components in GET_FARVAR(), which resulted in a
> bogus value for bpp, breaking output on most/all devices.  Fix this by
> adding GET_FARVAR() as appropriate.
> 
> Additionally, some newer ChromeOS devices still fail even with this fix,
> so fall back to using the coreboot reported bit depth if the calculated
> valid is invalid.

Thanks.  I committed this change.

-Kevin



More information about the SeaBIOS mailing list