[SeaBIOS] [PATCH 1/2] pvscsi: ring_desc do not have to be page aligned

Liran Alon liran.alon at oracle.com
Tue Nov 13 16:53:40 CET 2018


In contrast to other allocations made by pvscsi_init_rings(),
ring_desc is only used internally by SeaBIOS (not passed to
device-controller) and there is not restriction which force
it to be page aligned.

Reviewed-by: Mark Kanda <mark.kanda at oracle.com>
Signed-off-by: Liran Alon <liran.alon at oracle.com>
---
 src/hw/pvscsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/hw/pvscsi.c b/src/hw/pvscsi.c
index e0ea33cd751c..9d7d68d80964 100644
--- a/src/hw/pvscsi.c
+++ b/src/hw/pvscsi.c
@@ -167,7 +167,7 @@ pvscsi_init_rings(void *iobase, struct pvscsi_ring_dsc_s **ring_dsc)
 {
     struct PVSCSICmdDescSetupRings cmd = {0,};
 
-    struct pvscsi_ring_dsc_s *dsc = memalign_high(PAGE_SIZE, sizeof(*dsc));
+    struct pvscsi_ring_dsc_s *dsc = malloc_high(sizeof(*dsc));
     if (!dsc) {
         warn_noalloc();
         return;
-- 
2.16.1




More information about the SeaBIOS mailing list