[SeaBIOS] [PATCH v2 2/3] tpm: revert return values for successful/failed CRB probing

Stefan Berger stefanb at linux.vnet.ibm.com
Mon Mar 19 17:00:28 CET 2018


The return values for successful/failed CRB probing were reverted.
Fix it.

Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>
---
 src/hw/tpm_drivers.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/hw/tpm_drivers.c b/src/hw/tpm_drivers.c
index 7e6a96a..271f8d3 100644
--- a/src/hw/tpm_drivers.c
+++ b/src/hw/tpm_drivers.c
@@ -409,13 +409,13 @@ static u32 crb_probe(void)
 
     /* no support for 64 bit addressing yet */
     if (readl(CRB_REG(0, CRB_REG_CTRL_CMD_HADDR)))
-        return 1;
+        return 0;
 
     u64 addr = readq(CRB_REG(0, CRB_REG_CTRL_RSP_ADDR));
     if (addr > 0xffffffff)
-        return 1;
+        return 0;
 
-    return 0;
+    return 1;
 }
 
 static TPMVersion crb_get_tpm_version(void)
-- 
2.5.5




More information about the SeaBIOS mailing list