[SeaBIOS] [PATCH 3/3] qemu: add qemu ramfb support

[Gerd Hoffmann]

  Hi,

> It would be preferable to re-factor allocate_extra_stack() so there is
> just one pmm allocation function.

I'll try.

> > +    qemu_cfg_read_entry(&count, QEMU_CFG_FILE_DIR, sizeof(count));
> > +    count = be32_to_cpu(count);
> > +    u32 select, e, fb;
> > +    for (select = 0, e = 0; e < count; e++) {
> > +        struct QemuCfgFile qfile;
> > +        qemu_cfg_read(&qfile, sizeof(qfile));
> > +        if (memcmp_far(GET_SEG(SS), qfile.name,
> > +                       GET_SEG(CS), "etc/ramfb", 10) == 0)
> > +            select = be16_to_cpu(qfile.select);
> > +    }
> 
> Could this be moved into a new qemu_cfg_scan_file() function in
> paravirt.c, and thus avoid patch 2?

Can't be avoided completely ...

> > +    qemu_cfg_write_entry(&cfg, select, sizeof(cfg));

... because of this.  But, yes, should make the patch smaller and keep
more bits private to paravirt.c

I'll check this out.

> > +        config VGA_RAMFB
> > +            depends on QEMU
> > +            bool "qemu ram framebuffer (experimental)"
> > +            select VGA_EMULATE_TEXT
> > +            help
> > +                qemu ram framebuffer (experimental)
> 
> I see it is marked as experimental - is this a proof of concept patch
> or is this feature ready for a merge into qemu and seabios?

Oh, the experimental can be dropped now, will fix that.  qemu patches
should be merged soon.

cheers,
  Gerd