[SeaBIOS] [PATCH 1/2] nvme: add option to toggle probing only boot devices

[Gerd Hoffmann]

> > -        run_thread(nvme_controller_setup, pci);
> > +        if (should_setup_controller(pci)) {
> > +            run_thread(nvme_controller_setup, pci);
> > +        }
> >      }
> >  }
> 
> Thank you for the patch. Would it be better to make that a
> run-time option?

I think so.

You can ask for a strict boot order (qemu -boot strict=on).  seabios
will not try to boot any default boot entries then and only consider
devices which are explicitly specified as boot device.  It is
implemented by a "HALT" boot order entry.

So, skipping non-boot devices in case a HALT entry is present looks
pretty reasonable to me.  And there is no reason to restrict that to
nvme, a virtio-scsi controller could likewise initialize only the
disk(s) which have an boot order entry.

cheers,
  Gerd