[SeaBIOS] [PATCH] paravirt: Allow both Red Hat and Amazon PCI HB subsystem vendor and device ids

Gerd Hoffmann kraxel at redhat.com
Mon Jan 8 11:11:44 CET 2018


> >> @@ -83,8 +83,8 @@ static void qemu_detect(void)

> >> -    if (sv != 0x1af4 || /* Red Hat, Inc */
> >> -        sd != 0x1100)   /* Qemu virtual machine */
> >> +    if (!(sv == 0x1af4 && sd == 0x1100) && /* Red Hat, Inc. QEMU VM */
> >> +        !(sv == 0x1d0f && sd == 0x1237))   /* Amazon.com, Inc. i440fx VM */
> >>         return;
> > 
> > Is the above needed for a generally available VM software or product?
> > Or is this internal to Amazon?
> > 
> > -Kevin
> 
> 1d0f:1237 are the subsystem vendor and device ids of the i440fx emulation
> in the EC2 machine model, which is what we're using for:
> 
> * https://aws.amazon.com/ec2/instance-types/c5/
> * https://aws.amazon.com/ec2/instance-types/m5/
> 
> Today, the EC2 machine model isn't open source.

So I guess not based on qemu?  Otherwise you would have some GPL issues ...

How big are the differences to qemu?  Does it have fw_cfg?

Should we have a separate PF_EC2 flag?

> However, we're not excluding
> the option of making it generally available in the future.

That would be good.  Sometimes it is quite helpful to see the host-side
changes when reviewing firmware patches.

cheers,
  Gerd

PS: sorry for the delay, just back to work after weeks of sick leave due
    to a broken finger.



More information about the SeaBIOS mailing list