[SeaBIOS] [PATCH 1/2] scsi: ensure LUN0 is added first

Paolo Bonzini pbonzini at redhat.com
Wed Sep 27 09:36:01 CEST 2017


On 21/06/2017 00:44, Kevin O'Connor wrote:
>> Yes, I think so.  I'm not sure why virtqueues are allocated
>> in low memory.  Either cargo culting, or a remain of when
>> virtio was a 16-bit driver, if it ever was.
> The 'struct drive_s' storage currently must be allocated in the
> f-segment so that the disk.c code can access some critical details of
> mapped drives when in 16bit mode.  However, we could change the code
> to allocate that data separately from the controller specific data and
> then move the controller specific data to a larger memory pool. 

I don't think this is the issue.  virtqueues actually have been
allocated with memalign_high since 2015 (commit 6cfebb4e).

virtio-blk is allocating 68 fseg bytes for the controller-specific data,
virtio-scsi only 16.  struct drive_s is about 40 bytes long.

Paolo



More information about the SeaBIOS mailing list