[SeaBIOS] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

Marcel Apfelbaum marcel at redhat.com
Tue Aug 1 17:45:13 CEST 2017

On 01/08/2017 18:32, Michael S. Tsirkin wrote:
> On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote:
>>>> +typedef struct PCIEPCIBridge {
>>>> +    /*< private >*/
>>>> +    PCIBridge parent_obj;
>>>> +
>>>> +    bool msi_enable;
>>> Please rename the msi_enable property to "msi" in order
>>> to be aligned with the existent PCIBridgeDev and
>>> consider making it OnOffAuto for the same reason.
>>> (I am not sure about the last part though, we have
>>>   no meaning for "auto" here)
>> Agreed about "msi", but OnOffAuto looks weird to me
>> as we always want MSI to be enabled.

Hi Michael,

> Why even have a property then? Can't you enable it unconditionally?

Because of a current bug in Linux kernel:
msi will not work until the patch is merged. Even when
it will be merged, not all linux kernels will contain the patch.

Disabling msi is a workaround for the above case.


More information about the SeaBIOS mailing list