[SeaBIOS] [PATCH] vgabios: Reorder video modes to work around a Windows bug

Laszlo Ersek lersek at redhat.com
Thu Oct 20 09:42:40 CEST 2016


On 10/19/16 17:56, Kevin O'Connor wrote:
> On Wed, Oct 19, 2016 at 05:20:08PM +0200, Laszlo Ersek wrote:
>> On 10/19/16 15:16, Ladi Prosek wrote:
>>> Another hypothetical alternative would be to try to find an API
>>> invocation pattern reasonably unique to Windows that would trigger the
>>> new behavior, to minimize the risk.
>>
>> How about a new CONFIG_xxx knob?
> 
> I doubt QEMU would want to ship two stdvga vgabios binaries for this -
> one with the flag and one without.

Likely not, but with the config option present, downstreams that care
about a well-defined set of guest OSes could exhaustively test the
behavior of those guests, and if the change worked fine for all of the
OSes, they could just flip the config option in the downstream package
(rather than carrying a downstream patch).

It was just an idea anyway; if it's too late for the pending release, I
guess a more robust method could be devised, in time for the next release.

Thanks
Laszlo



More information about the SeaBIOS mailing list